From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kthrq-0000Ol-Ui
	for qemu-devel@nongnu.org; Sat, 25 Oct 2008 08:03:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kthrp-0000OX-FV
	for qemu-devel@nongnu.org; Sat, 25 Oct 2008 08:03:42 -0400
Received: from [199.232.76.173] (port=56026 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kthrp-0000OU-Cn
	for qemu-devel@nongnu.org; Sat, 25 Oct 2008 08:03:41 -0400
Received: from rv-out-0708.google.com ([209.85.198.245]:48185)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1Kthrp-0005N5-2u
	for qemu-devel@nongnu.org; Sat, 25 Oct 2008 08:03:41 -0400
Received: by rv-out-0708.google.com with SMTP id f25so1171795rvb.22
	for <qemu-devel@nongnu.org>; Sat, 25 Oct 2008 05:03:40 -0700 (PDT)
Message-ID: <fb249edb0810250503n5742179aqfe1bab3928d1f4a5@mail.gmail.com>
Date: Sat, 25 Oct 2008 14:03:40 +0200
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] [5532] Replace uses of strndup (a GNU extension)
	with Qemu pstrdup
In-Reply-To: <E1KthEt-0006Tr-CT@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1KthEt-0006Tr-CT@cvs.savannah.gnu.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

2008/10/25 Blue Swirl <blauwirbel@gmail.com>:
> Revision: 5532
>          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5532
> Author:   blueswir1
> Date:     2008-10-25 11:23:27 +0000 (Sat, 25 Oct 2008)
>
> Log Message:
> -----------
> Replace uses of strndup (a GNU extension) with Qemu pstrdup
>
> Modified Paths:
> --------------
>    trunk/cutils.c
>    trunk/hw/bt-hci.c
>    trunk/qemu-common.h
>
> Modified: trunk/cutils.c
> ===================================================================
> --- trunk/cutils.c      2008-10-25 11:21:28 UTC (rev 5531)
> +++ trunk/cutils.c      2008-10-25 11:23:27 UTC (rev 5532)
> @@ -50,6 +50,18 @@
>     return buf;
>  }
>
> +/* strdup with a limit */
> +char *pstrdup(const char *str, size_t buf_size)
> +{
> +    size_t len;
> +    char *buf;
> +
> +    len = MIN(buf_size, strlen(str));
> +    buf = qemu_malloc(len);
> +    pstrcpy(buf, len, str);
> +    return buf;
> +}

I think here also pstrcpy will only copy up to buf_size - 1 characters
while strndup would copy buf_size chars.

Cheers