From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KxIGS-0005y9-V2
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 04:31:56 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KxIGR-0005xQ-8g
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 04:31:56 -0500
Received: from [199.232.76.173] (port=47219 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KxIGQ-0005xB-Oj
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 04:31:54 -0500
Received: from rv-out-0506.google.com ([209.85.198.226]:12900)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1KxIGQ-0003Rt-5q
	for qemu-devel@nongnu.org; Tue, 04 Nov 2008 04:31:54 -0500
Received: by rv-out-0506.google.com with SMTP id g9so1406225rvb.6
	for <qemu-devel@nongnu.org>; Tue, 04 Nov 2008 01:31:52 -0800 (PST)
Message-ID: <fb249edb0811040131r2991e2bwc0ec416162dfcee5@mail.gmail.com>
Date: Tue, 4 Nov 2008 10:31:52 +0100
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] vga optmization
In-Reply-To: <20081103173111.GC30410@poweredge.glommer>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20081103173111.GC30410@poweredge.glommer>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

Hi,

2008/11/3 Glauber Costa <glommer@redhat.com>:
[...]
> diff --git a/cpu-all.h b/cpu-all.h
> index cdd79bc..9118f4d 100644
> --- a/cpu-all.h
> +++ b/cpu-all.h
> @@ -46,6 +46,8 @@
>
>  #ifdef BSWAP_NEEDED
>
> +#include "kvm.h"
> +
>  static inline uint16_t tswap16(uint16_t s)
>  {
>     return bswap16(s);
> @@ -909,17 +911,10 @@ int cpu_memory_rw_debug(CPUState *env, target_ulong addr,
>  #define KQEMU_DIRTY_FLAG     0x04
>  #define MIGRATION_DIRTY_FLAG 0x08
>
> -/* read dirty bit (return 0 or 1) */
> -static inline int cpu_physical_memory_is_dirty(ram_addr_t addr)
> -{
> -    return phys_ram_dirty[addr >> TARGET_PAGE_BITS] == 0xff;
> -}
> +int cpu_physical_memory_get_dirty(ram_addr_t addr, int dirty_flags);
> +int cpu_physical_memory_is_dirty(ram_addr_t addr);
>
> -static inline int cpu_physical_memory_get_dirty(ram_addr_t addr,
> -                                                int dirty_flags)
> -{
> -    return phys_ram_dirty[addr >> TARGET_PAGE_BITS] & dirty_flags;
> -}
> +void qemu_physical_sync_dirty_bitmap(ram_addr_t start_addr);

This will prevent the functions from being inlined even if KVM is
disabled (e.g. on other archs) and I think it could be easily
retained.

Cheers