From: "andrzej zaborowski" <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH, v2] Rewrite mmap_find_vma() to work fine on 64-bit hosts with 32-bit targets
Date: Mon, 10 Nov 2008 04:54:35 +0100 [thread overview]
Message-ID: <fb249edb0811091954xb1ea970ud0ce23558da00078@mail.gmail.com> (raw)
In-Reply-To: <20081101165543.GA5076@localhost.localdomain>
Hi,
2008/11/1 Kirill A. Shutemov <kirill@shutemov.name>:
> On Sat, Nov 01, 2008 at 04:51:10PM +0000, Jamie Lokier wrote:
>> Kirill A. Shutemov wrote:
>> > + /* Unmap and try again with new page */
>> > + munmap(ptr, size);
>> > addr += qemu_host_page_size;
>>
>> Won't this be rather slow if it has to skip a large mapped area, one
>> page at a time?
>
> If we skip more than one page we increase memory fragmentation.
This approach makes sense, however the iterating over all pages may
indeed have performance consequences, plus it would be great if people
who better know linux-user/ than me commented. I'll assume that
everyone is happy with this otherwise.
It may be useful adding a comment on top of the function that it must
be called with mmap_lock held.
Cheers
next prev parent reply other threads:[~2008-11-10 3:54 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 10:10 [Qemu-devel] [PATCH] Add readahead syscall Kirill A. Shutemov
2008-10-13 10:10 ` [Qemu-devel] [PATCH] Fix getdents* syscalls Kirill A. Shutemov
2008-10-13 10:10 ` [Qemu-devel] [PATCH] Fix and cleanup IPCOP_msg* ipc calls handling Kirill A. Shutemov
2008-10-13 10:10 ` [Qemu-devel] [PATCH] Implement msg* syscalls Kirill A. Shutemov
2008-10-13 10:10 ` [Qemu-devel] [PATCH] Fix and cleanup IPCOP_sem* ipc calls handling Kirill A. Shutemov
2008-10-13 10:10 ` [Qemu-devel] [PATCH] Implement sem* syscalls Kirill A. Shutemov
2008-10-13 10:10 ` [Qemu-devel] [PATCH] Fix and cleanup IPCOP_shm* ipc calls handling Kirill A. Shutemov
2008-10-13 10:10 ` [Qemu-devel] [PATCH] Implement shm* syscalls Kirill A. Shutemov
2008-10-13 10:10 ` [Qemu-devel] [PATCH] Fix fstatat64()/newfstatat() syscall implementation Kirill A. Shutemov
2008-10-13 10:10 ` [Qemu-devel] [PATCH] Introduce --enable-binfmt-misc configure option Kirill A. Shutemov
2008-10-13 10:10 ` [Qemu-devel] [PATCH] Rewrite mmap_find_vma() to work fine on 64-bit hosts with 32-bit targets Kirill A. Shutemov
2008-10-13 10:10 ` [Qemu-devel] [PATCH] mremap(): handle MREMAP_FIXED and MREMAP_MAYMOVE correctly Kirill A. Shutemov
2008-10-13 10:10 ` [Qemu-devel] [PATCH] shmat(): use mmap_find_vma to find free memory area Kirill A. Shutemov
2008-10-17 6:34 ` [Qemu-devel] [PATCH] mmap: add check if requested memory area fits target address space Kirill A. Shutemov
2008-10-17 6:34 ` [Qemu-devel] [PATCH] linux-user, x86: use target_mmap() to allocate idt, gdt and ldt tables Kirill A. Shutemov
2008-11-01 9:33 ` [Qemu-devel] " Jan Kiszka
2008-11-01 10:27 ` Kirill A. Shutemov
2008-11-01 10:54 ` Jan Kiszka
2008-11-01 11:12 ` Kirill A. Shutemov
2008-11-01 11:16 ` Kirill A. Shutemov
2008-11-02 19:36 ` Jan Kiszka
2008-11-01 11:34 ` Laurent Desnogues
2008-11-01 10:06 ` [Qemu-devel] [PATCH, v2] " Kirill A. Shutemov
2008-10-27 13:08 ` [Qemu-devel] [PATCH] mmap: add check if requested memory area fits target address space andrzej zaborowski
2008-10-27 15:48 ` Kirill A. Shutemov
2008-10-27 15:55 ` Andreas Schwab
2008-10-27 17:32 ` Kirill A. Shutemov
2008-10-27 19:37 ` andrzej zaborowski
2008-10-27 20:06 ` Kirill A. Shutemov
2008-11-10 3:30 ` andrzej zaborowski
2008-11-10 5:55 ` Kirill A. Shutemov
2008-11-10 12:45 ` andrzej zaborowski
2008-10-27 17:48 ` [Qemu-devel] [PATCH, v2] " Kirill A. Shutemov
2008-11-10 7:11 ` [Qemu-devel] [PATCH, v3] " Kirill A. Shutemov
2008-11-10 7:09 ` [Qemu-devel] [PATCH, v3] shmat(): use mmap_find_vma to find free memory area Kirill A. Shutemov
2008-10-14 4:04 ` [Qemu-devel] [PATCH] mremap(): handle MREMAP_FIXED and MREMAP_MAYMOVE correctly Vince Weaver
2008-10-14 5:22 ` Kirill A. Shutemov
2008-10-26 16:14 ` [Qemu-devel] [PATCH] Rewrite mmap_find_vma() to work fine on 64-bit hosts with 32-bit targets Vince Weaver
2008-10-27 17:49 ` [Qemu-devel] [PATCH, v2] " Kirill A. Shutemov
2008-11-01 16:51 ` Jamie Lokier
2008-11-01 16:55 ` Kirill A. Shutemov
2008-11-10 3:54 ` andrzej zaborowski [this message]
2008-11-10 6:07 ` Kirill A. Shutemov
2008-11-10 8:02 ` Jamie Lokier
2008-11-10 12:55 ` andrzej zaborowski
2008-11-10 14:38 ` Kirill A. Shutemov
2008-11-11 0:53 ` Jamie Lokier
2008-11-14 12:23 ` Kirill A. Shutemov
2008-11-14 12:51 ` Paul Brook
2008-11-14 13:08 ` Jamie Lokier
2008-11-14 13:51 ` Kirill A. Shutemov
2008-11-10 7:07 ` [Qemu-devel] [PATCH, v3] " Kirill A. Shutemov
2008-11-14 13:57 ` [Qemu-devel] [PATCH, v4] " Kirill A. Shutemov
2008-11-01 10:10 ` [Qemu-devel] [PATCH, v2] Introduce --enable-binfmt-misc configure option Kirill A. Shutemov
2008-11-10 13:03 ` andrzej zaborowski
2008-10-16 20:55 ` [Qemu-devel] [PATCH] Implement shm* syscalls + Implement sem* syscalls Martin Mohring
2008-10-17 4:09 ` Kirill A. Shutemov
2008-10-17 8:27 ` Martin Mohring
2008-10-17 10:12 ` Kirill A. Shutemov
2008-11-01 9:56 ` Aurelien Jarno
2008-11-01 10:08 ` Kirill A. Shutemov
2008-10-24 7:24 ` [Qemu-devel] Re: [PATCH] Fix and cleanup IPCOP_sem* ipc calls handling Kirill A. Shutemov
2008-10-13 21:09 ` [Qemu-devel] [PATCH] Implement msg* syscalls Aurelien Jarno
2008-10-13 15:53 ` [Qemu-devel] [PATCH] Fix and cleanup IPCOP_msg* ipc calls handling Aurelien Jarno
2008-10-13 18:48 ` Kirill A. Shutemov
2008-10-13 20:52 ` Aurelien Jarno
2008-10-13 21:09 ` Aurelien Jarno
2008-10-13 12:48 ` [Qemu-devel] [PATCH] Fix getdents* syscalls Aurelien Jarno
2008-10-13 12:59 ` Kirill A. Shutemov
2008-10-13 13:10 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0811091954xb1ea970ud0ce23558da00078@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).