From: "andrzej zaborowski" <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] r5531 made x509 certs not loadable [PATCH]
Date: Wed, 12 Nov 2008 17:53:01 +0100 [thread overview]
Message-ID: <fb249edb0811120853p64b3075brf1663c22beb7863b@mail.gmail.com> (raw)
In-Reply-To: <1226498200.6434.101.camel@henrik-desktop>
2008/11/12 Henrik Holst <henrik@witsbits.com>:
> The patch in r5531 which replaced a bunch of strncpy with pstrcpy causes
> the x509 credentials from the -vnc parameter to be one character shorter
> than entered meaning that there is currently no way to enter x509
> certificates...
>
> The attached patch fixes this. Also the path[len]='\0' is unnecessary
> now that pstrcpy is used. The problem was that the previous strncpy was
> called correctly which the r5531 patch didn't think. And due to how the
> code is a memcpy could probably be used instead...
Thanks for spotting. I made it a qemu_strndup instead because that's
basically what's being implemented here (to be exact it could be a
memdup() here because the length is already known). Please test.
Cheers
next prev parent reply other threads:[~2008-11-12 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 13:56 [Qemu-devel] r5531 made x509 certs not loadable [PATCH] Henrik Holst
2008-11-12 16:53 ` andrzej zaborowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-14 14:39 Henrik Holst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0811120853p64b3075brf1663c22beb7863b@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).