From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L5pfV-0003k0-JO
	for qemu-devel@nongnu.org; Thu, 27 Nov 2008 17:49:05 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L5pfT-0003hn-N6
	for qemu-devel@nongnu.org; Thu, 27 Nov 2008 17:49:04 -0500
Received: from [199.232.76.173] (port=51230 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L5pfT-0003hd-Gh
	for qemu-devel@nongnu.org; Thu, 27 Nov 2008 17:49:03 -0500
Received: from rv-out-0708.google.com ([209.85.198.249]:57904)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1L5pfS-0003CB-NB
	for qemu-devel@nongnu.org; Thu, 27 Nov 2008 17:49:03 -0500
Received: by rv-out-0708.google.com with SMTP id f25so1083640rvb.22
	for <qemu-devel@nongnu.org>; Thu, 27 Nov 2008 14:49:00 -0800 (PST)
Message-ID: <fb249edb0811271449iaec0cc3j9e2188cc0f45a5b8@mail.gmail.com>
Date: Thu, 27 Nov 2008 23:49:00 +0100
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] typo in target-i386/ops_sse.h
In-Reply-To: <200811272230.12559.frank.mehnert@sun.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200811272230.12559.frank.mehnert@sun.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi,

2008/11/27 Frank Mehnert <Frank.Mehnert@sun.com>:
> I believe there is a typo in target-i386/ops_sse.h in the macro
> SSE_HELPER_F:

Ooops, you're right about the typo, but I think it should something like this:
--- a/target-i386/ops_sse.h
+++ b/target-i386/ops_sse.h
@@ -1499,12 +1499,12 @@ void glue(name, SUFFIX) (Reg *d, Reg *s)\
 {\
     d->elem(0) = F(0);\
     d->elem(1) = F(1);\
-    d->elem(2) = F(2);\
-    d->elem(3) = F(3);\
-    if (num > 3) {\
-        d->elem(4) = F(4);\
-        d->elem(5) = F(5);\
-        if (num > 5) {\
+    if (num > 2) {\
+        d->elem(2) = F(2);\
+        d->elem(3) = F(3);\
+        if (num > 4) {\
+            d->elem(4) = F(4);\
+            d->elem(5) = F(5);\
             d->elem(6) = F(6);\
             d->elem(7) = F(7);\
         }\

I'm not sure why this didn't generate warnings.

Cheers