From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LFzRy-0003JJ-Dm
	for qemu-devel@nongnu.org; Thu, 25 Dec 2008 18:17:06 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LFzRu-0003Fy-Hm
	for qemu-devel@nongnu.org; Thu, 25 Dec 2008 18:17:05 -0500
Received: from [199.232.76.173] (port=48946 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LFzRu-0003Fv-C0
	for qemu-devel@nongnu.org; Thu, 25 Dec 2008 18:17:02 -0500
Received: from rv-out-0708.google.com ([209.85.198.240]:8476)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1LFzRt-00070O-UK
	for qemu-devel@nongnu.org; Thu, 25 Dec 2008 18:17:02 -0500
Received: by rv-out-0708.google.com with SMTP id f25so3210972rvb.22
	for <qemu-devel@nongnu.org>; Thu, 25 Dec 2008 15:17:01 -0800 (PST)
Message-ID: <fb249edb0812251517qb583656ma28cf65fd406ad29@mail.gmail.com>
Date: Fri, 26 Dec 2008 00:17:01 +0100
From: "andrzej zaborowski" <balrogg@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] evdev_keycode_map
In-Reply-To: <493FD5DD.2020704@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <d9c105ea0809241610g39c2e2dfn20c66c81de8af446@mail.gmail.com>
	<20081209224235.GA12529@kos.to> <20081210112845.GC22446@redhat.com>
	<493FD5DD.2020704@codemonkey.ws>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Dustin Kirkland <kirkland@canonical.com>

2008/12/10 Anthony Liguori <anthony@codemonkey.ws>:
> Daniel P. Berrange wrote:
>>
>> On Wed, Dec 10, 2008 at 12:42:35AM +0200, Riku Voipio wrote:
>>
>>>
>>> On Wed, Sep 24, 2008 at 06:10:27PM -0500, Dustin Kirkland wrote:
>>>
>>>>
>>>> I'm attaching a patch that we have applied to the qemu implementation
>>>> inside of the kvm package in Ubuntu.
>>>>
>>>
>>> Anyone know why this patch is still lingering?
>>>
>>>
>>>>
>>>> --- kvm-72+dfsg/qemu/configure  2008-07-27 08:20:10.000000000 -0500
>>>> +++ kvm-72+dfsg/qemu/configure  2008-09-24 16:04:28.036791147 -0500
>>>> @@ -1198,9 +1198,9 @@ if test "$sdl1" = "yes" ; then
>>>>   echo "#define CONFIG_SDL 1" >> $config_h
>>>>   echo "CONFIG_SDL=yes" >> $config_mak
>>>>   if test "$target_softmmu" = "no" -o "$static" = "yes"; then
>>>> -    echo "SDL_LIBS=$sdl_static_libs" >> $config_mak
>>>> +    echo "SDL_LIBS=-lX11 $sdl_static_libs" >> $config_mak
>>>>   else
>>>> -    echo "SDL_LIBS=`$sdl_config --libs`" >> $config_mak
>>>> +    echo "SDL_LIBS=-lX11 `$sdl_config --libs`" >> $config_mak
>>>>   fi
>>>>
>>>
>>> These changes make the SDL code dependant on X ? This
>>> would make compiling windows less trivial..
>>>
>>
>> It ought to be possible to just #ifdef out the bit of the code which
>> checks for evdev on non-Linux, and just default to the existing mapping QEMU
>> had.
>>
>
> This is what's required for merging.  SDL X11 support needs to be probed at
> configure time, an appropriate #define needs to be added to config.h, and
> then the detection code needs to be enabled conditionally based on that
> #define.
>
> Otherwise, non-X11 SDL platforms will stop building which certainly isn't
> acceptable.

You can have X11 support compiled in and not use it, SDL can be
compiled with >1 backends.

Cheers