From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhAz7-00055g-4o for qemu-devel@nongnu.org; Tue, 10 Mar 2009 19:03:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhAz5-00055F-2D for qemu-devel@nongnu.org; Tue, 10 Mar 2009 19:03:40 -0400 Received: from [199.232.76.173] (port=32819 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhAz4-00055C-Qg for qemu-devel@nongnu.org; Tue, 10 Mar 2009 19:03:38 -0400 Received: from mail-fx0-f175.google.com ([209.85.220.175]:64859) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LhAz4-0000u8-4Q for qemu-devel@nongnu.org; Tue, 10 Mar 2009 19:03:38 -0400 Received: by fxm23 with SMTP id 23so1845072fxm.34 for ; Tue, 10 Mar 2009 16:03:35 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <49B422DD.3080300@web.de> References: <20090221190054.12485.30486.stgit@mchn012c.ww002.siemens.net> <20090221190055.12485.61603.stgit@mchn012c.ww002.siemens.net> <49B3DC8C.6050700@web.de> <20090308184444.GT32521@hall.aurel32.net> <49B422DD.3080300@web.de> Date: Wed, 11 Mar 2009 00:03:35 +0100 Message-ID: Subject: Re: [Qemu-devel] [PATCH] clean build: Add bt-host.h From: andrzej zaborowski Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Aurelien Jarno 2009/3/8 Jan Kiszka : > Aurelien Jarno wrote: >> On Sun, Mar 08, 2009 at 03:56:12PM +0100, Jan Kiszka wrote: >>> Jan Kiszka wrote: >>>> Silence compiler warning by providing a prototype in the CONFIG_BLUEZ >>>> case (hw/bt.h provides it otherwise). >>>> >>>> Signed-off-by: Jan Kiszka >>>> --- >>>> >>>> =C2=A0bt-host.c | =C2=A0 =C2=A02 ++ >>>> =C2=A01 files changed, 2 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/bt-host.c b/bt-host.c >>>> index 07679f6..066757a 100644 >>>> --- a/bt-host.c >>>> +++ b/bt-host.c >>>> @@ -31,6 +31,8 @@ >>>> =C2=A0# =C2=A0include >>>> =C2=A0# =C2=A0include >>>> =C2=A0# =C2=A0include >>>> +/* Silence compiler warning */ >>>> +struct HCIInfo *bt_host_hci(const char *id); >>>> =C2=A0# else >>>> =C2=A0# =C2=A0include "hw/bt.h" >>>> =C2=A0# =C2=A0define HCI_MAX_FRAME_SIZE =C2=A0 =C2=A0 =C2=A0 1028 >>> Thanks for applying the other patches, but this tiny one always seems t= o >>> be ignored - for unknown reasons. :) >>> >> >> On my side, I consider that a hack, not a fix. We should make sure the >> correct header is included so that this function is declared. >> > > As always: no comment means no progress. This one better? Is it? struct HCIInfo is defined in net.h so maybe this one belongs there too. I'd much rather turn off the unhelpful warnings, some of them caused developers to add code that is both more hacky and slower. I also think we could save many header files like the hw/virtio-*.h, at this granularity they don't help with compile times which was the reason vl.h was split. Regards