From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1My9ju-0002bv-A5
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 15:42:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1My9jo-0002Yr-J0
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 15:42:24 -0400
Received: from [199.232.76.173] (port=40407 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1My9jo-0002Yi-Co
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 15:42:20 -0400
Received: from mail-fx0-f214.google.com ([209.85.220.214]:41922)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <balrogg@gmail.com>) id 1My9jn-0005k6-Ua
	for qemu-devel@nongnu.org; Wed, 14 Oct 2009 15:42:20 -0400
Received: by fxm10 with SMTP id 10so160315fxm.8
	for <qemu-devel@nongnu.org>; Wed, 14 Oct 2009 12:42:18 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <m3y6ndlqq1.fsf@neno.mitica>
References: <cover.1255541443.git.quintela@redhat.com>
	<aa493ca196bc4ae428fb1781558def4aab7757a3.1255541443.git.quintela@redhat.com>
	<fb249edb0910141115u12e74455y662ad8e2c9eacca5@mail.gmail.com>
	<m3y6ndlqq1.fsf@neno.mitica>
Date: Wed, 14 Oct 2009 21:42:18 +0200
Message-ID: <fb249edb0910141242n14096a6fx511800352f616b02@mail.gmail.com>
From: andrzej zaborowski <balrogg@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH 12/16] vmware_vga: remove !EMBED_STDVGA code
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

2009/10/14 Juan Quintela <quintela@redhat.com>:
> andrzej zaborowski <balrogg@gmail.com> wrote:
>> 2009/10/14 Juan Quintela <quintela@redhat.com>:
>>> It don't compile. =C2=A0And the trivial fixes (change vga.foo field to =
foo field
>>> don't work either. =C2=A0No output
>>
>> Just a note that there's supposed to be no output because your guest
>> OS (and BIOS) expect the standard VGA functionality to be there. =C2=A0T=
he
>> define is only useful for debugging vmware_vga or OS driver. =C2=A0It's =
ok
>> to drop it if you want.
>
> I preffer to drop it because it has no chance of working (suspend/resume
> code is not there for instance).
>
> Once that we are there. =C2=A0I did a fast try at enabling DIRECT_VRAM wi=
th
> the same not working result. =C2=A0Any idea if it would make things
> better/fast/... whatever?

Currently it probably makes things slower.  I have not digged through
the newer SDL code deep enough, to tell if it's possible to create a
SDL surface directly from guest RAM provided it's contiguously mapped
on host -- this is what VMware does and it's one of the expected
benefits from using vmware_vga that isn't there, and I think using DGA
saves them another unneeded copy.  This would need reimplementing the
pieces guarded by #ifdef DIRECT_VRAM.

Cheers