From: andrzej zaborowski <balrogg@gmail.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] tcg/arm fixes and improvements
Date: Tue, 2 Mar 2010 22:44:36 +0100 [thread overview]
Message-ID: <fb249edb1003021344m47f8b7dewfd48a8aa00014868@mail.gmail.com> (raw)
In-Reply-To: <1267479230-1964-1-git-send-email-aurelien@aurel32.net>
On 1 March 2010 22:33, Aurelien Jarno <aurelien@aurel32.net> wrote:
> This patch series fix a bug in div2/divu2 ops, implement setcond
> and setcond2 ops and improve brcond/setcond by allowing immediate
> constants.
Thanks, pushed the four changes + added a missing break after
setcond2. I'm not totally sure but I think setcond can be shortened
to two instructions for each case or some cases, the COND_NE case
could look like:
subs dest, t1, t2
movne dest, #1
and the lesser/greater cases can use the carry flag and "adc".
Cheers
prev parent reply other threads:[~2010-03-02 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 21:33 [Qemu-devel] tcg/arm fixes and improvements Aurelien Jarno
2010-03-01 21:33 ` [Qemu-devel] [PATCH 1/4] tcg/arm: fix div2/divu2 Aurelien Jarno
2010-03-01 21:33 ` [Qemu-devel] [PATCH 2/4] tcg/arm: implement setcond Aurelien Jarno
2010-03-01 21:33 ` [Qemu-devel] [PATCH 3/4] tcg/arm: implement setcond2 Aurelien Jarno
2010-03-01 21:33 ` [Qemu-devel] [PATCH 4/4] tcg/arm: accept immediate arguments for brcond/setcond Aurelien Jarno
2010-03-02 21:44 ` andrzej zaborowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb1003021344m47f8b7dewfd48a8aa00014868@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).