From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NmZtQ-0005ko-4B for qemu-devel@nongnu.org; Tue, 02 Mar 2010 16:44:40 -0500 Received: from [199.232.76.173] (port=34987 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NmZtP-0005kV-Hm for qemu-devel@nongnu.org; Tue, 02 Mar 2010 16:44:39 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NmZtO-0005BD-S7 for qemu-devel@nongnu.org; Tue, 02 Mar 2010 16:44:39 -0500 Received: from mail-fx0-f214.google.com ([209.85.220.214]:55562) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NmZtO-0005B7-H3 for qemu-devel@nongnu.org; Tue, 02 Mar 2010 16:44:38 -0500 Received: by fxm6 with SMTP id 6so865438fxm.2 for ; Tue, 02 Mar 2010 13:44:36 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1267479230-1964-1-git-send-email-aurelien@aurel32.net> References: <1267479230-1964-1-git-send-email-aurelien@aurel32.net> Date: Tue, 2 Mar 2010 22:44:36 +0100 Message-ID: Subject: Re: [Qemu-devel] tcg/arm fixes and improvements From: andrzej zaborowski Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 1 March 2010 22:33, Aurelien Jarno wrote: > This patch series fix a bug in div2/divu2 ops, implement setcond > and setcond2 ops and improve brcond/setcond by allowing immediate > constants. Thanks, pushed the four changes + added a missing break after setcond2. I'm not totally sure but I think setcond can be shortened to two instructions for each case or some cases, the COND_NE case could look like: subs dest, t1, t2 movne dest, #1 and the lesser/greater cases can use the carry flag and "adc". Cheers