From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Evgeny Iakovlev" <eiakovlev@linux.microsoft.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Gavin Shan" <gshan@redhat.com>,
qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH v3 9/10] hw/char/pl011: Add transmit FIFO to PL011State
Date: Fri, 13 Oct 2023 11:14:17 -0700 [thread overview]
Message-ID: <fb26bbac-e573-431e-a4b4-13ca65a24455@linaro.org> (raw)
In-Reply-To: <87edhylac2.fsf@linaro.org>
On 10/13/23 10:05, Alex Bennée wrote:
>> @@ -487,7 +505,11 @@ static const VMStateDescription vmstate_pl011 = {
>> .subsections = (const VMStateDescription * []) {
>> &vmstate_pl011_clock,
>> NULL
>> - }
>> + },
>> + .subsections = (const VMStateDescription * []) {
>> + &vmstate_pl011_xmit_fifo,
>> + NULL
>> + },
>> };
>
> Doesn't this necessitate the bumping of the migration version data or
> do we not worry about new -> old migrations?
We usually don't care about new->old, however:
If the fifo is empty, migration will still work because of the subsection.
If the fifo is not empty... I think the subsection will be ignored, with the only
consequence being that some characters will be dropped.
r~
next prev parent reply other threads:[~2023-10-13 18:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 14:11 [PATCH v3 0/10] hw/char/pl011: Implement TX (async) FIFO to avoid blocking the main loop Philippe Mathieu-Daudé
2023-10-13 14:11 ` [PATCH v3 1/10] util/fifo8: Allow fifo8_pop_buf() to not populate popped length Philippe Mathieu-Daudé
2023-10-13 14:11 ` [PATCH v3 2/10] util/fifo8: Introduce fifo8_peek_buf() Philippe Mathieu-Daudé
2023-10-13 16:59 ` Alex Bennée
2023-10-13 14:11 ` [PATCH v3 3/10] hw/char/pl011: Split RX/TX path of pl011_reset_fifo() Philippe Mathieu-Daudé
2023-10-13 14:11 ` [PATCH v3 4/10] hw/char/pl011: Extract pl011_write_txdata() from pl011_write() Philippe Mathieu-Daudé
2023-10-13 14:11 ` [PATCH v3 5/10] hw/char/pl011: Extract pl011_read_rxdata() from pl011_read() Philippe Mathieu-Daudé
2023-10-13 14:11 ` [PATCH v3 6/10] hw/char/pl011: Warn when using disabled transmitter Philippe Mathieu-Daudé
2023-10-13 14:11 ` [PATCH v3 7/10] hw/char/pl011: Check if receiver is enabled Philippe Mathieu-Daudé
2023-10-13 14:11 ` [PATCH v3 8/10] hw/char/pl011: Rename RX FIFO methods Philippe Mathieu-Daudé
2023-10-13 14:11 ` [PATCH v3 9/10] hw/char/pl011: Add transmit FIFO to PL011State Philippe Mathieu-Daudé
2023-10-13 17:05 ` Alex Bennée
2023-10-13 18:14 ` Richard Henderson [this message]
2023-10-13 17:08 ` [PATCH v3 0/10] hw/char/pl011: Implement TX (async) FIFO to avoid blocking the main loop Alex Bennée
2023-10-14 6:40 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb26bbac-e573-431e-a4b4-13ca65a24455@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=eiakovlev@linux.microsoft.com \
--cc=gshan@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).