qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Chris Wulff" <crwulff@gmail.com>,
	devel@lists.libvirt.org, "Marek Vasut" <marex@denx.de>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>
Subject: Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation
Date: Wed, 27 Mar 2024 14:19:21 +0100	[thread overview]
Message-ID: <fb28d3b0-1ab9-4423-80ef-03a285cf02d7@redhat.com> (raw)
In-Reply-To: <7aad7197-21f3-4c0e-931c-2eb4febdf94a@linaro.org>

On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote:
> On 27/3/24 13:35, Philippe Mathieu-Daudé wrote:
>> Remove the Nios II machines and the system emulation code
>> (deprecated since v8.2 in commit 9997771bc1 "target/nios2:
>> Deprecate the Nios II architecture").

Please remind me, why didn't we deprecate the linux-user emulation, too?

>> diff --git a/hw/nios2/Kconfig b/hw/nios2/Kconfig
>> deleted file mode 100644
>> index 4748ae27b6..0000000000
>> --- a/hw/nios2/Kconfig
>> +++ /dev/null
>> @@ -1,13 +0,0 @@
>> -config NIOS2_10M50
>> -    bool
>> -    select NIOS2
>> -    select SERIAL
>> -    select ALTERA_TIMER
> 
> I forgot to mention I deliberately chose to keep the Altera
> timer model in the tree, since it looks like a re-usable
> IP component.

But if it is not used anymore by any machine, this will happily bitrot, 
won't it? I think I'd rather remove it, too ... maybe in a separate patch, 
so that in case somebody later needs it again, it can be restored by simply 
reverting the patch again.

  Thomas



  reply	other threads:[~2024-03-27 13:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27 12:35 [PATCH-for-9.1] target/nios2: Remove machines and system emulation Philippe Mathieu-Daudé
2024-03-27 12:45 ` Philippe Mathieu-Daudé
2024-03-27 13:19   ` Thomas Huth [this message]
2024-03-27 14:15     ` Philippe Mathieu-Daudé
2024-03-27 15:39       ` Thomas Huth
2024-03-27 17:00         ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb28d3b0-1ab9-4423-80ef-03a285cf02d7@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=crwulff@gmail.com \
    --cc=devel@lists.libvirt.org \
    --cc=eblake@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=lvivier@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=marex@denx.de \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).