[Qemu-devel] [PATCH] qemu: Fix incorrect zlib check error

[Qemu-devel] [PATCH] qemu: Fix incorrect zlib check error

[Deepa Srinivasan]

# HG changeset patch
# User Deepa Srinivasan <deepas@us.ibm.com>
# Date 1226685276 21600
# Node ID ae59be00a22c4769a1116943ca5e07cec9154de0
# Parent  1a74ac23ff60cc2ab052072243dc4ff47faf5849
qemu: Fix incorrect zlib check error

From: Deepa Srinivasan <deepas@us.ibm.com>

Include the CFLAGS and LDFLAGS variables in the check for zlib. When cross-compiling
for PowerPC, the path for zlib headers and libraries are passed in the CFLAGS
and LDFLAGS respectively. While this patch fixes only the check for zlib,
this issue potentially affects other configure tests as well.

Signed-off-by: Deepa Srinivasan <deepas@us.ibm.com>
---

[diffstat]
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[diff]

diff -r 1a74ac23ff60 -r ae59be00a22c qemu/configure
--- a/qemu/configure	Fri Nov 14 10:53:36 2008 -0600
+++ b/qemu/configure	Fri Nov 14 11:54:36 2008 -0600
@@ -798,7 +798,7 @@ cat > $TMPC << EOF
 #include <zlib.h>
 int main(void) { zlibVersion(); return 0; }
 EOF
-if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $TMPC -lz 2> /dev/null ; then
+if $cc $ARCH_CFLAGS -o $TMPE ${OS_CFLAGS} $CFLAGS $LDFLAGS $TMPC -lz 2> /dev/null ; then
     :
 else
     echo

Re: [Qemu-devel] [PATCH] qemu: Fix incorrect zlib check error

[Hollis Blanchard]

On Fri, Nov 14, 2008 at 11:57 AM, Deepa Srinivasan <deepas@us.ibm.com> wrote:
> qemu: Fix incorrect zlib check error
>
> From: Deepa Srinivasan <deepas@us.ibm.com>
>
> Include the CFLAGS and LDFLAGS variables in the check for zlib. When cross-compiling
> for PowerPC, the path for zlib headers and libraries are passed in the CFLAGS
> and LDFLAGS respectively. While this patch fixes only the check for zlib,
> this issue potentially affects other configure tests as well.

Doesn't anybody else cross-compile qemu? AFAICS, this patch is
required to specify the location of cross-built libraries like zlib.

-Hollis

Re: [Qemu-devel] [PATCH] qemu: Fix incorrect zlib check error

[Anthony Liguori]

Hollis Blanchard wrote:
> On Fri, Nov 14, 2008 at 11:57 AM, Deepa Srinivasan <deepas@us.ibm.com> wrote:
>   
>> qemu: Fix incorrect zlib check error
>>
>> From: Deepa Srinivasan <deepas@us.ibm.com>
>>
>> Include the CFLAGS and LDFLAGS variables in the check for zlib. When cross-compiling
>> for PowerPC, the path for zlib headers and libraries are passed in the CFLAGS
>> and LDFLAGS respectively. While this patch fixes only the check for zlib,
>> this issue potentially affects other configure tests as well.
>>     
>
> Doesn't anybody else cross-compile qemu? AFAICS, this patch is
> required to specify the location of cross-built libraries like zlib.
>   

That's if you're using --extra-cflags.  I cross compile without using 
--extra-cflags by installing libraries in the path of the cross 
environment.  For instance, I have a /usr/i586-mingw32msvc path and the 
include/ directory in their has a zlib.h.  This is what will be used by 
default.

Regards,

Anthony Liguori

> -Hollis
>
>
>   

Re: [Qemu-devel] [PATCH] qemu: Fix incorrect zlib check error

[Anthony Liguori]

Deepa Srinivasan wrote:
> # HG changeset patch
> # User Deepa Srinivasan <deepas@us.ibm.com>
> # Date 1226685276 21600
> # Node ID ae59be00a22c4769a1116943ca5e07cec9154de0
> # Parent  1a74ac23ff60cc2ab052072243dc4ff47faf5849
> qemu: Fix incorrect zlib check error
>
> From: Deepa Srinivasan <deepas@us.ibm.com>
>
> Include the CFLAGS and LDFLAGS variables in the check for zlib. When cross-compiling
> for PowerPC, the path for zlib headers and libraries are passed in the CFLAGS
> and LDFLAGS respectively. While this patch fixes only the check for zlib,
> this issue potentially affects other configure tests as well.
>
> Signed-off-by: Deepa Srinivasan <deepas@us.ibm.com>
>   

Please submit this patch against QEMU, and not against kvm-userspace.

Regards,

Anthony Liguori

Re: [Qemu-devel] [PATCH] qemu: Fix incorrect zlib check error

[Deepa Srinivasan]

[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]


Per the discussion on this mailing list (i.e. installing libraries in the
right location) and the update on
http://kvm.qumranet.com/kvmwiki/PowerPC_Host_Userspace by Hollis Blanchard,
this fix is no longer needed.

Thanks,
Deepa Srinivasan

qemu-devel-bounces+deepas=us.ibm.com@nongnu.org wrote on 11/18/2008
05:12:05 PM:

> Deepa Srinivasan wrote:
> > # HG changeset patch
> > # User Deepa Srinivasan <deepas@us.ibm.com>
> > # Date 1226685276 21600
> > # Node ID ae59be00a22c4769a1116943ca5e07cec9154de0
> > # Parent  1a74ac23ff60cc2ab052072243dc4ff47faf5849
> > qemu: Fix incorrect zlib check error
> >
> > From: Deepa Srinivasan <deepas@us.ibm.com>
> >
> > Include the CFLAGS and LDFLAGS variables in the check for zlib.
> When cross-compiling
> > for PowerPC, the path for zlib headers and libraries are passed inthe
CFLAGS
> > and LDFLAGS respectively. While this patch fixes only the check for
zlib,
> > this issue potentially affects other configure tests as well.
> >
> > Signed-off-by: Deepa Srinivasan <deepas@us.ibm.com>
> >
>
> Please submit this patch against QEMU, and not against kvm-userspace.
>
> Regards,
>
> Anthony Liguori
>
>
>

[-- Attachment #2: Type: text/html, Size: 1596 bytes --]