From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MgPlL-0007mn-Vl
	for qemu-devel@nongnu.org; Wed, 26 Aug 2009 17:10:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MgPlH-0007jV-Fq
	for qemu-devel@nongnu.org; Wed, 26 Aug 2009 17:10:35 -0400
Received: from [199.232.76.173] (port=52919 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MgPlH-0007jS-D3
	for qemu-devel@nongnu.org; Wed, 26 Aug 2009 17:10:31 -0400
Received: from mail-pz0-f192.google.com ([209.85.222.192]:59047)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <slightlyunconventional@gmail.com>)
	id 1MgPlH-0006fA-30
	for qemu-devel@nongnu.org; Wed, 26 Aug 2009 17:10:31 -0400
Received: by pzk30 with SMTP id 30so593543pzk.4
	for <qemu-devel@nongnu.org>; Wed, 26 Aug 2009 14:10:29 -0700 (PDT)
MIME-Version: 1.0
Sender: slightlyunconventional@gmail.com
In-Reply-To: <fb6652759c6a5f980d8abe72f5bbeb58f160fd10.1249301360.git.quintela@redhat.com>
References: <cover.1249301360.git.quintela@redhat.com>
	<fb6652759c6a5f980d8abe72f5bbeb58f160fd10.1249301360.git.quintela@redhat.com>
Date: Wed, 26 Aug 2009 14:10:27 -0700
Message-ID: <fb412d760908261410q4613fa24w5cff66afd1756d4a@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 70/81] remove last 3 uses of :=, everywhere
	else uses += or =
From: Hollis Blanchard <hollis@penguinppc.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Mon, Aug 3, 2009 at 5:47 AM, Juan Quintela<quintela@redhat.com> wrote:
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> =A0Makefile.target | =A0 =A06 +++---
> =A01 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index a4d269d..6b3d40f 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -20,7 +20,7 @@ endif
> =A0PROGS=3D$(QEMU_PROG)
>
> =A0ifeq ($(subst ppc64,ppc,$(ARCH))$(TARGET_BASE_ARCH),ppcppc)
> -translate.o: QEMU_CFLAGS :=3D $(QEMU_CFLAGS) $(call cc-option, $(QEMU_CF=
LAGS), -fno-unit-at-a-time,)
> +translate.o: QEMU_CFLAGS +=3D $(call cc-option, $(QEMU_CFLAGS), -fno-uni=
t-at-a-time,)
> =A0endif
>
> =A0LIBS+=3D-lm

This change breaks the build with PPC host and PPC target:
Makefile:25: *** Recursive variable `QEMU_CFLAGS' references itself
(eventually).  Stop.

I don't know why you want to remove all :=3D, but it seems like this
hunk should be reverted.

-Hollis