From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MgQmN-0001JM-S3 for qemu-devel@nongnu.org; Wed, 26 Aug 2009 18:15:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MgQmI-0001J9-6G for qemu-devel@nongnu.org; Wed, 26 Aug 2009 18:15:42 -0400 Received: from [199.232.76.173] (port=39050 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MgQmH-0001J6-UZ for qemu-devel@nongnu.org; Wed, 26 Aug 2009 18:15:37 -0400 Received: from mail-pz0-f192.google.com ([209.85.222.192]:60168) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MgQmH-0000Lk-DY for qemu-devel@nongnu.org; Wed, 26 Aug 2009 18:15:37 -0400 Received: by pzk30 with SMTP id 30so628850pzk.4 for ; Wed, 26 Aug 2009 15:15:36 -0700 (PDT) MIME-Version: 1.0 Sender: slightlyunconventional@gmail.com In-Reply-To: References: Date: Wed, 26 Aug 2009 15:15:36 -0700 Message-ID: Subject: Re: [Qemu-devel] Re: [PATCH 70/81] remove last 3 uses of :=, everywhere else uses += or = From: Hollis Blanchard Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On Wed, Aug 26, 2009 at 2:46 PM, Juan Quintela wrote: > Hollis Blanchard wrote: >> On Mon, Aug 3, 2009 at 5:47 AM, Juan Quintela wrote= : >>> >>> Signed-off-by: Juan Quintela >>> --- >>> =A0Makefile.target | =A0 =A06 +++--- >>> =A01 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/Makefile.target b/Makefile.target >>> index a4d269d..6b3d40f 100644 >>> --- a/Makefile.target >>> +++ b/Makefile.target >>> @@ -20,7 +20,7 @@ endif >>> =A0PROGS=3D$(QEMU_PROG) >>> >>> =A0ifeq ($(subst ppc64,ppc,$(ARCH))$(TARGET_BASE_ARCH),ppcppc) >>> -translate.o: QEMU_CFLAGS :=3D $(QEMU_CFLAGS) $(call cc-option, $(QEMU_= CFLAGS), -fno-unit-at-a-time,) >>> +translate.o: QEMU_CFLAGS +=3D $(call cc-option, $(QEMU_CFLAGS), -fno-u= nit-at-a-time,) >>> =A0endif >>> >>> =A0LIBS+=3D-lm >> >> This change breaks the build with PPC host and PPC target: >> Makefile:25: *** Recursive variable `QEMU_CFLAGS' references itself >> (eventually). =A0Stop. >> >> I don't know why you want to remove all :=3D, but it seems like this >> hunk should be reverted. > > Could you check two things: > > a- remove the whole block, it should not be needed anymore (or that I > =A0 have been told) The original commit, from malc, says it's necessary to work around a gcc 4.3.0 bug. If that's true, it's probably not a great idea to remove it. > b- if a) don't work, tryng to change the interior bit to > > translate.o: QEMU_CFLAGS +=3D $(call cc-option, $(CFLAGS),-fno-unit-at-a-= time,) > > And if so, we can do this change. =A0What we pass as 2nd argument > shouldn't matter for this test. > > call cc-option is complicated to get right, sorry :( If it doesn't matter, better not to pass anything, rather than confuse the reader into thinking it does matter. This seems to work: translate.o: QEMU_CFLAGS +=3D $(call cc-option, , -fno-unit-at-a-time,) But strangely, this doesn't: translate.o: QEMU_CFLAGS +=3D $(call cc-option, "", -fno-unit-at-a-time,) However, what if the second argument did matter? I don't understand the problem with the original syntax. Debugging makefiles sucks. -Hollis