From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: mreitz@redhat.com, den@openvz.org, jcody@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/7] qcow: Support .bdrv_co_create
Date: Fri, 9 Mar 2018 15:58:55 -0600 [thread overview]
Message-ID: <fb503893-a9e0-2772-41f2-14934b199f8d@redhat.com> (raw)
In-Reply-To: <20180309214611.19122-4-kwolf@redhat.com>
On 03/09/2018 03:46 PM, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to qcow, which
> enables image creation over QMP.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qapi/block-core.json | 21 +++++-
> block/qcow.c | 196 ++++++++++++++++++++++++++++++++++-----------------
> 2 files changed, 150 insertions(+), 67 deletions(-)
Pre-review question: do we REALLY want to support creation of new qcow
images from QMP? Or are we at the point where we want to declare qcow a
read-only format where we only support it to the extent that you can
convert an existing qcow file into a better supported format like qcow2?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-03-09 21:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 21:46 [Qemu-devel] [PATCH 0/7] block: .bdrv_co_create for format drivers Kevin Wolf
2018-03-09 21:46 ` [Qemu-devel] [PATCH 1/7] parallels: Support .bdrv_co_create Kevin Wolf
2018-03-12 16:40 ` Max Reitz
2018-03-12 21:30 ` Jeff Cody
2018-03-09 21:46 ` [Qemu-devel] [PATCH 2/7] qemu-iotests: Enable write tests for parallels Kevin Wolf
2018-03-12 16:42 ` Max Reitz
2018-03-12 21:31 ` Jeff Cody
2018-03-09 21:46 ` [Qemu-devel] [PATCH 3/7] qcow: Support .bdrv_co_create Kevin Wolf
2018-03-09 21:58 ` Eric Blake [this message]
2018-03-12 12:20 ` Kevin Wolf
2018-03-12 16:49 ` Max Reitz
2018-03-12 21:31 ` Jeff Cody
2018-03-14 11:16 ` Eric Blake
2018-03-14 11:19 ` Daniel P. Berrangé
2018-03-09 21:46 ` [Qemu-devel] [PATCH 4/7] qed: " Kevin Wolf
2018-03-09 22:01 ` Eric Blake
2018-03-12 21:20 ` Max Reitz
2018-03-09 21:46 ` [Qemu-devel] [PATCH 5/7] vdi: " Kevin Wolf
2018-03-12 21:22 ` Max Reitz
2018-03-09 21:46 ` [Qemu-devel] [PATCH 6/7] vhdx: " Kevin Wolf
2018-03-12 19:37 ` Jeff Cody
2018-03-12 21:38 ` Max Reitz
2018-03-09 21:46 ` [Qemu-devel] [PATCH 7/7] vpc: " Kevin Wolf
2018-03-12 21:49 ` Max Reitz
2018-03-13 11:32 ` Kevin Wolf
2018-03-13 12:25 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb503893-a9e0-2772-41f2-14934b199f8d@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).