From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Serge Guelton <sguelton@redhat.com>, qemu-devel@nongnu.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH] Fix typo in CFI build documentation
Date: Wed, 21 Apr 2021 15:55:22 +0200 [thread overview]
Message-ID: <fb5eb9f9-7087-6a95-34e2-a23fd045e8bb@redhat.com> (raw)
In-Reply-To: <1618933722-18022-1-git-send-email-sguelton@redhat.com>
Hi Serge,
Cc'ing qemu-trivial@
On 4/20/21 5:48 PM, serge-sans-paille wrote:
> Signed-off-by: serge-sans-paille <sguelton@redhat.com>
It looks your git-config is misconfigured... Maybe you used
an incorrect profile :) Can you repost please?
> ---
> docs/devel/control-flow-integrity.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
For the fix:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> diff --git a/docs/devel/control-flow-integrity.rst b/docs/devel/control-flow-integrity.rst
> index d89d707..e6b73a4 100644
> --- a/docs/devel/control-flow-integrity.rst
> +++ b/docs/devel/control-flow-integrity.rst
> @@ -39,7 +39,7 @@ later).
> Given the use of LTO, a version of AR that supports LLVM IR is required.
> The easies way of doing this is by selecting the AR provided by LLVM::
>
> - AR=llvm-ar-9 CC=clang-9 CXX=lang++-9 /path/to/configure --enable-cfi
> + AR=llvm-ar-9 CC=clang-9 CXX=clang++-9 /path/to/configure --enable-cfi
>
> CFI is enabled on every binary produced.
>
> @@ -131,7 +131,7 @@ lld with version 11+.
> In other words, to compile with fuzzing and CFI, clang 11+ is required, and
> lld needs to be used as a linker::
>
> - AR=llvm-ar-11 CC=clang-11 CXX=lang++-11 /path/to/configure --enable-cfi \
> + AR=llvm-ar-11 CC=clang-11 CXX=clang++-11 /path/to/configure --enable-cfi \
> -enable-fuzzing --extra-ldflags="-fuse-ld=lld"
>
> and then, compile the fuzzers as usual.
>
next prev parent reply other threads:[~2021-04-21 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 15:48 [PATCH] Fix typo in CFI build documentation serge-sans-paille
2021-04-21 13:55 ` Philippe Mathieu-Daudé [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-22 8:33 Serge Guelton
2021-04-30 13:20 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb5eb9f9-7087-6a95-34e2-a23fd045e8bb@redhat.com \
--to=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sguelton@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).