From: Stafford Horne <shorne@gmail.com>
To: qemu-devel@nongnu.org
Cc: openrisc@lists.librecores.org, Stafford Horne <shorne@gmail.com>
Subject: [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic
Date: Mon, 17 Apr 2017 08:23:51 +0900 [thread overview]
Message-ID: <fb69c137317a365dcb549dfef1ecd2fbff48e92c.1492384862.git.shorne@gmail.com> (raw)
In-Reply-To: <cover.1492384862.git.shorne@gmail.com>
In-Reply-To: <cover.1492384862.git.shorne@gmail.com>
In openrisc simulators we use hooks like 'l.nop 1' to cause the
simulator to exit. Implement that for qemu too.
Reported-by: Waldemar Brodkorb <wbx@openadk.org>
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
target/openrisc/helper.h | 1 +
target/openrisc/sys_helper.c | 17 +++++++++++++++++
target/openrisc/translate.c | 5 ++++-
3 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/target/openrisc/helper.h b/target/openrisc/helper.h
index 4fd1a6b..b7838f5 100644
--- a/target/openrisc/helper.h
+++ b/target/openrisc/helper.h
@@ -59,3 +59,4 @@ DEF_HELPER_FLAGS_1(rfe, 0, void, env)
/* sys */
DEF_HELPER_FLAGS_4(mtspr, 0, void, env, tl, tl, tl)
DEF_HELPER_FLAGS_4(mfspr, TCG_CALL_NO_WG, tl, env, tl, tl, tl)
+DEF_HELPER_1(nop, void, i32)
diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c
index 60c3193..2eaff87 100644
--- a/target/openrisc/sys_helper.c
+++ b/target/openrisc/sys_helper.c
@@ -22,6 +22,7 @@
#include "cpu.h"
#include "exec/exec-all.h"
#include "exec/helper-proto.h"
+#include "sysemu/sysemu.h"
#define TO_SPR(group, number) (((group) << 11) + (number))
@@ -286,3 +287,19 @@ target_ulong HELPER(mfspr)(CPUOpenRISCState *env,
/* for rd is passed in, if rd unchanged, just keep it back. */
return rd;
}
+
+/* In openrisc simulators nop can be used to do intersting
+ * things like shut down the simulator */
+void HELPER(nop)(uint32_t arg)
+{
+#ifndef CONFIG_USER_ONLY
+ switch (arg) {
+ case 0x001: /* NOP_EXIT */
+ case 0x00c: /* NOP_EXIT_SILENT */
+ qemu_system_shutdown_request();
+ break;
+ default:
+ break;
+ }
+#endif
+}
diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c
index 7c4cbf2..74df245 100644
--- a/target/openrisc/translate.c
+++ b/target/openrisc/translate.c
@@ -755,8 +755,11 @@ static void dec_misc(DisasContext *dc, uint32_t insn)
switch (op1) {
case 0x01: /* l.nop */
LOG_DIS("l.nop %d\n", I16);
+ {
+ TCGv_i32 arg = tcg_const_i32(I16);
+ gen_helper_nop(arg);
+ }
break;
-
default:
gen_illegal_exception(dc);
break;
--
2.9.3
next prev parent reply other threads:[~2017-04-16 23:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-16 23:23 [Qemu-devel] [PATCH 0/7] Openrisc misc features / fixes Stafford Horne
2017-04-16 23:23 ` [Qemu-devel] [PATCH 1/7] target/openrisc: Fixes for memory debugging Stafford Horne
2017-04-18 7:47 ` Richard Henderson
2017-04-18 14:18 ` Stafford Horne
2017-04-18 15:00 ` Richard Henderson
2017-04-19 20:06 ` Stafford Horne
2017-04-16 23:23 ` Stafford Horne [this message]
2017-04-18 7:52 ` [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic Richard Henderson
2017-04-18 14:20 ` Stafford Horne
2017-04-22 10:09 ` Stafford Horne
2017-04-22 15:25 ` Richard Henderson
2017-04-23 21:54 ` [Qemu-devel] [PATCH RFC] target/openrisc: Support non-busy idle state using PMR SPR Stafford Horne
2017-04-25 10:11 ` Richard Henderson
2017-04-25 14:10 ` [Qemu-devel] [PATCH RFC v2] " Stafford Horne
2017-04-25 14:18 ` [Qemu-devel] [PATCH RFC] " Stafford Horne
2017-04-25 14:51 ` Richard Henderson
2022-04-27 17:44 ` [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic Jason A. Donenfeld
2022-04-27 18:47 ` Peter Maydell
2022-04-27 21:48 ` Stafford Horne
2022-04-28 0:04 ` Jason A. Donenfeld
2022-04-28 11:16 ` Jason A. Donenfeld
2022-04-28 11:47 ` Stafford Horne
2022-04-28 9:19 ` Peter Maydell
2017-04-16 23:23 ` [Qemu-devel] [PATCH 3/7] target/openrisc: add numcores and coreid support Stafford Horne
2017-04-18 8:01 ` Richard Henderson
2017-04-16 23:23 ` [Qemu-devel] [PATCH 4/7] target/openrisc: implement shadow registers Stafford Horne
2017-04-18 8:11 ` Richard Henderson
2017-04-18 14:26 ` Stafford Horne
2017-04-16 23:23 ` [Qemu-devel] [PATCH 5/7] migration: Add VMSTATE_UINTTL_2DARRAY() Stafford Horne
2017-04-16 23:23 ` [Qemu-devel] [PATCH 6/7] migration: Add VMSTATE_STRUCT_2DARRAY() Stafford Horne
2017-04-16 23:23 ` [Qemu-devel] [PATCH 7/7] target/openrisc: Implement full vmstate serialization Stafford Horne
2017-04-18 8:14 ` Richard Henderson
2017-04-18 14:27 ` Stafford Horne
2017-04-16 23:33 ` [Qemu-devel] [PATCH 0/7] Openrisc misc features / fixes no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb69c137317a365dcb549dfef1ecd2fbff48e92c.1492384862.git.shorne@gmail.com \
--to=shorne@gmail.com \
--cc=openrisc@lists.librecores.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).