From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [PATCH 0/3] fix build failures from incorrectly skipped container build jobs
Date: Tue, 16 Feb 2021 11:39:18 +0100 [thread overview]
Message-ID: <fb7ba9b2-622f-8a79-ae72-7d84f51f6d41@redhat.com> (raw)
In-Reply-To: <20210208163339.1159514-1-berrange@redhat.com>
On 2/8/21 5:33 PM, Daniel P. Berrangé wrote:
> This series fixes a problem with our gitlab CI rules that cause
> container builds to be skipped. See the commit description in the
> first patch for the details on this problem.
...
> There is still a race condition though where build jobs can run
> with the wrong containers. This happens if you push two different
> branches to gitlab with different docker file content. If the
> container jobs for the 2nd branch finish before the 1st
> branch runs its build jobs, the 1st branch can end up using
> containers fro the second branch. The only fix to truely fix
> that would be to stop using "latest" docker tag and always
> use a tag based on the branch name. This would mean we build
> up a growing set of docker images in the gitlab registry.
OK this indeed describes the problem I'm facing.
> At least this series is much more correct that what exists in
> git currently.
Good, I'll test it then.
Regards,
Phil.
prev parent reply other threads:[~2021-02-16 10:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 16:33 [PATCH 0/3] fix build failures from incorrectly skipped container build jobs Daniel P. Berrangé
2021-02-08 16:33 ` [PATCH 1/3] gitlab: always build container images Daniel P. Berrangé
2021-02-09 6:37 ` Thomas Huth
2021-02-09 9:58 ` Daniel P. Berrangé
2021-02-10 11:17 ` Daniel P. Berrangé
2021-02-16 12:43 ` Daniel P. Berrangé
2021-02-16 13:02 ` Philippe Mathieu-Daudé
2021-02-16 13:15 ` Daniel P. Berrangé
2021-02-08 16:33 ` [PATCH 2/3] gitlab: add fine grained job deps for all build jobs Daniel P. Berrangé
2021-02-09 6:39 ` Thomas Huth
2021-02-08 16:33 ` [PATCH 3/3] gitlab: fix inconsistent indentation Daniel P. Berrangé
2021-02-08 17:20 ` Philippe Mathieu-Daudé
2021-02-08 17:22 ` [PATCH 0/3] fix build failures from incorrectly skipped container build jobs Daniel P. Berrangé
2021-02-08 18:08 ` Philippe Mathieu-Daudé
2021-02-08 18:12 ` Daniel P. Berrangé
2021-02-09 6:01 ` Stefan Weil
2021-02-09 6:55 ` Thomas Huth
2021-02-09 9:53 ` Daniel P. Berrangé
2021-02-16 10:39 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb7ba9b2-622f-8a79-ae72-7d84f51f6d41@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).