From: Halil Pasic <pasic@linux.vnet.ibm.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/5] migration/vmstate: fix array of ptr with nullptrs
Date: Mon, 27 Feb 2017 15:02:17 +0100 [thread overview]
Message-ID: <fb8ac151-a375-9c2b-a241-fbff879c3492@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170224122954.GA8830@work-vm>
On 02/24/2017 01:29 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pasic@linux.vnet.ibm.com) wrote:
>> Make VMS_ARRAY_OF_POINTER cope with null pointers. Previously the
>> reward for trying to migrate an array with some null pointers in it was
>> an illegal memory access, that is a swift and painless death of the
>> process. Let's make vmstate cope with this scenario.
>>
>> The general approach is, when we encounter a null pointer (element),
>> instead of following the pointer to save/load the data behind it, we
>> save/load a placeholder. This way we can detect if we expected a null
>> pointer at the load side but not null data was saved instead.
>>
>> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
>> Reviewed-by: Guenther Hutzl <hutzl@linux.vnet.ibm.com>
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
Thanks! Seems there are no further objections. Is the series going in
via your tree (softfreeze starting 28.02, me worried)?
Regards,
Halil
next prev parent reply other threads:[~2017-02-27 14:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 16:01 [Qemu-devel] [PATCH v2 0/5] vmstate: handle arrays with null ptrs Halil Pasic
2017-02-22 16:01 ` [Qemu-devel] [PATCH v2 1/5] migration/vmstate: renames in (load|save)_state Halil Pasic
2017-02-22 16:01 ` [Qemu-devel] [PATCH v2 2/5] migration/vmstate: split up vmstate_base_addr Halil Pasic
2017-02-22 16:01 ` [Qemu-devel] [PATCH v2 3/5] migration/vmstate: fix array of ptr with nullptrs Halil Pasic
2017-02-24 12:29 ` Dr. David Alan Gilbert
2017-02-27 14:02 ` Halil Pasic [this message]
2017-02-27 19:00 ` Dr. David Alan Gilbert
2017-02-22 16:01 ` [Qemu-devel] [PATCH v2 4/5] tests/test-vmstate.c: test array of ptr with null Halil Pasic
2017-02-22 16:01 ` [Qemu-devel] [PATCH v2 5/5] tests/test-vmstate.c: test array of ptr to primitive Halil Pasic
2017-02-28 9:36 ` [Qemu-devel] [PATCH v2 0/5] vmstate: handle arrays with null ptrs Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb8ac151-a375-9c2b-a241-fbff879c3492@linux.vnet.ibm.com \
--to=pasic@linux.vnet.ibm.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).