From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MYzNW-0007Xm-Bw
	for qemu-devel@nongnu.org; Thu, 06 Aug 2009 05:35:18 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MYzNR-0007U4-Cp
	for qemu-devel@nongnu.org; Thu, 06 Aug 2009 05:35:17 -0400
Received: from [199.232.76.173] (port=57347 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MYzNR-0007Tl-3a
	for qemu-devel@nongnu.org; Thu, 06 Aug 2009 05:35:13 -0400
Received: from mail-yx0-f188.google.com ([209.85.210.188]:61366)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <atar4qemu@googlemail.com>) id 1MYzNQ-0007Ec-Hj
	for qemu-devel@nongnu.org; Thu, 06 Aug 2009 05:35:12 -0400
Received: by yxe26 with SMTP id 26so881092yxe.4
	for <qemu-devel@nongnu.org>; Thu, 06 Aug 2009 02:35:12 -0700 (PDT)
MIME-Version: 1.0
Date: Thu, 6 Aug 2009 11:35:12 +0200
Message-ID: <fb8d4f70908060235m1a3a47c4r9713b5c695298159@mail.gmail.com>
From: Artyom Tarasenko <atar4qemu@googlemail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] sparc32 double "Set CPU IRQ 14"
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>

I observe double "Set CPU IRQ 14" in the log.  I don't see how  the
real harware would be able to generate the same irq twice, without
resetting it. I put a printf in cpuexec.c:

#elif defined(TARGET_SPARC)
                    if ((interrupt_request & CPU_INTERRUPT_HARD) &&
                        cpu_interrupts_enabled(env)) {
                        int pil = env->interrupt_index & 15;
                        int type = env->interrupt_index & 0xf0;

                        if (((type == TT_EXTINT) &&
                             (pil == 15 || pil > env->psrpil)) ||
                            type != TT_EXTINT) {
                            env->interrupt_request &= ~CPU_INTERRUPT_HARD;
                            env->exception_index = env->interrupt_index;
                            do_interrupt(env);
                            env->interrupt_index = 0;
#if !defined(CONFIG_USER_ONLY)
               printf("cpuexec calls cpu_check_irqs\n");
                            cpu_check_irqs(env);
#endif
                        next_tb = 0;
                        }


And now my log looks like this:

CPUIRQ: Raise CPU IRQ 14
CPUIRQ: Set CPU IRQ 14
cpuexec calls cpu_check_irqs
CPUIRQ: Set CPU IRQ 14

Does it look like cpuexec does an unnecessary call of cpu_check_irqs ?

I've removed this call, and see no difference: OBP works the same,
OpenBIOS too, NetBSD boot log also seems to be the same.

What this call is needed for?

Artyom