From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MiAIj-0004T6-Rj for qemu-devel@nongnu.org; Mon, 31 Aug 2009 13:04:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MiAIf-0004Ry-UD for qemu-devel@nongnu.org; Mon, 31 Aug 2009 13:04:17 -0400 Received: from [199.232.76.173] (port=54606 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MiAIf-0004Ru-N1 for qemu-devel@nongnu.org; Mon, 31 Aug 2009 13:04:13 -0400 Received: from an-out-0708.google.com ([209.85.132.247]:19365) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MiAIf-0005D9-4j for qemu-devel@nongnu.org; Mon, 31 Aug 2009 13:04:13 -0400 Received: by an-out-0708.google.com with SMTP id c38so1507982ana.37 for ; Mon, 31 Aug 2009 10:04:11 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Artyom Tarasenko Date: Mon, 31 Aug 2009 19:03:51 +0200 Message-ID: Content-Type: multipart/mixed; boundary=001636ed6caad2124904727305dc Subject: [Qemu-devel] [PATCH] esp (sparc32) Extra scsi data. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel , Blue Swirl --001636ed6caad2124904727305dc Content-Type: text/plain; charset=ISO-8859-1 > ESP: Message Accepted (12) > ESP: Transfer status (sense=0) > ESP: read reg[5]: 0x20 > ESP: read reg[4]: 0x07 > ESP: read reg[7]: 0x02 > Extra scsi data. Fatal error. It looks like "Message Accepted" shouldn't write a response. At least ESP_RFLAGS must definetely be 0. With the following fix OBP goes one step further: Signed-off-by: Artyom Tarasenko --- diff --git a/hw/esp.c b/hw/esp.c index aad547e..cc97eb4 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -528,9 +528,10 @@ static void esp_mem_writeb(void *opaque, target_phys_addr_t addr, uint32_t val) break; case CMD_MSGACC: DPRINTF("Message Accepted (%2.2x)\n", val); - write_response(s); s->rregs[ESP_RINTR] = INTR_DC; s->rregs[ESP_RSEQ] = 0; + s->rregs[ESP_RFLAGS] = 0; + esp_raise_irq(s); break; case CMD_PAD: DPRINTF("Transfer padding (%2.2x)\n", val); --001636ed6caad2124904727305dc Content-Type: text/plain; charset=US-ASCII; name="0001-esp-message-accepted-no-response.patch" Content-Disposition: attachment; filename="0001-esp-message-accepted-no-response.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fz1gloi60 U2lnbmVkLW9mZi1ieTogQXJ0eW9tIFRhcmFzZW5rbyA8YXRhcjRxZW11QGdtYWlsLmNvbT4KLS0t CmRpZmYgLS1naXQgYS9ody9lc3AuYyBiL2h3L2VzcC5jCmluZGV4IGFhZDU0N2UuLmNjOTdlYjQg MTAwNjQ0Ci0tLSBhL2h3L2VzcC5jCisrKyBiL2h3L2VzcC5jCkBAIC01MjgsOSArNTI4LDEwIEBA IHN0YXRpYyB2b2lkIGVzcF9tZW1fd3JpdGViKHZvaWQgKm9wYXF1ZSwgdGFyZ2V0X3BoeXNfYWRk cl90IGFkZHIsIHVpbnQzMl90IHZhbCkKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNl IENNRF9NU0dBQ0M6CiAgICAgICAgICAgICBEUFJJTlRGKCJNZXNzYWdlIEFjY2VwdGVkICglMi4y eClcbiIsIHZhbCk7Ci0gICAgICAgICAgICB3cml0ZV9yZXNwb25zZShzKTsKICAgICAgICAgICAg IHMtPnJyZWdzW0VTUF9SSU5UUl0gPSBJTlRSX0RDOwogICAgICAgICAgICAgcy0+cnJlZ3NbRVNQ X1JTRVFdID0gMDsKKyAgICAgICAgICAgIHMtPnJyZWdzW0VTUF9SRkxBR1NdID0gMDsKKyAgICAg ICAgICAgIGVzcF9yYWlzZV9pcnEocyk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2Fz ZSBDTURfUEFEOgogICAgICAgICAgICAgRFBSSU5URigiVHJhbnNmZXIgcGFkZGluZyAoJTIuMngp XG4iLCB2YWwpOwo= --001636ed6caad2124904727305dc--