From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N36lF-00062a-5g
	for qemu-devel@nongnu.org; Wed, 28 Oct 2009 07:32:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N36l9-00060U-5c
	for qemu-devel@nongnu.org; Wed, 28 Oct 2009 07:32:15 -0400
Received: from [199.232.76.173] (port=48559 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N36l8-00060F-HF
	for qemu-devel@nongnu.org; Wed, 28 Oct 2009 07:32:10 -0400
Received: from mail-gx0-f223.google.com ([209.85.217.223]:64690)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <atar4qemu@googlemail.com>) id 1N36l8-0004KF-4I
	for qemu-devel@nongnu.org; Wed, 28 Oct 2009 07:32:10 -0400
Received: by gxk23 with SMTP id 23so750440gxk.2
	for <qemu-devel@nongnu.org>; Wed, 28 Oct 2009 04:32:09 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <fb8d4f70910271109r2b2fb673v57667ea54182e207@mail.gmail.com>
References: <fb8d4f70910260636j74e11d89o9ad1fe274f98421f@mail.gmail.com>
	<4AE735FE.3080806@codemonkey.ws>
	<fb8d4f70910271109r2b2fb673v57667ea54182e207@mail.gmail.com>
From: Artyom Tarasenko <atar4qemu@googlemail.com>
Date: Wed, 28 Oct 2009 12:31:49 +0100
Message-ID: <fb8d4f70910280431u3a2dbb7bv4b9ce640467be04f@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] scsi-disk: Inquiry with allocation length of
	CDB < 36
Content-Type: text/plain; charset=ISO-8859-1
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

2009/10/27 Artyom Tarasenko <atar4qemu@googlemail.com>:
> 2009/10/27 Anthony Liguori <anthony@codemonkey.ws>:
>> Artyom Tarasenko wrote:
>>>
>>> According to SCSI-2 specification,
>>> http://ldkelley.com/SCSI2/SCSI2/SCSI2/SCSI2-08.html#8.2.5 ,
>>> "if the allocation length of the command descriptor block (CDB) is too
>>> small to transfer
>>> all of the parameters, the additional length shall not be adjusted to
>>> reflect the truncation."
>>> The 36 mandatory bytes of response are written to outbuf, and then
>>> only the length requested
>>> in CDB is transferred.
>>>
>>> Signed-off-by: Artyom Tarasenko <atar4qemu@gmail.com>
>>>
>>
>> This patch is whitespace damaged.
>
> Also the attached one? I tried to keep the original indentation: used
> tabs where the tabs originally were.

What is actually the indentation policy for patches? Should they be
conform with CODING_STYLE even if the original code isn't?
If they are conform the code may look badly indented with any tab
settings, including the ones from the original author.
If they keep author's indentation, the code still may look badly
indented with the CODING_STYLE tab settings.

Should patches for badly indented code explicitly require
indentation-only patches which shall be applied before?