[Qemu-devel] Re: [FOR 0.12 PATCH] scsi-disk: Inquiry with allocation length of CDB < 36 (v3)

[Artyom Tarasenko <atar4qemu@googlemail.com>]

2009/12/13 Blue Swirl <blauwirbel@gmail.com>:
> On Sat, Dec 12, 2009 at 7:24 PM, Artyom Tarasenko
> <atar4qemu@googlemail.com> wrote:
>> According to the SCSI-2 specification,
>> http://ldkelley.com/SCSI2/SCSI2/SCSI2/SCSI2-08.html#8.2.5 ,
>> "if the allocation length of the command descriptor block (CDB) is too
>> small to transfer all of the parameters, the additional length shall
>> not be adjusted to reflect the truncation."
>> The 36 mandatory bytes of response are written to outbuf, and then
>> only the length requested in CDB is transferred.
>> ---
>> Signed-off-by: Artyom Tarasenko <atar4qemu@gmail.com>
>
> Please leave out "---" between body and SoB in the future, now the SoB
> is automagically dropped by git-am.

Thanks, still learning how to use git send.

> The patch applies cleanly, but:
/src/qemu/hw/scsi-disk.c:441: error: 'len' undeclared

Arrgh. Instead of v3 I just re-submitted the old patch which was
white-space damaged before (back then there was a variable "len").
Let's consider it being a test  for sending patches via git send. I'll
wear brown paperbag for the next two days.

-- 
Regards,
Artyom Tarasenko

solaris/sparc under qemu blog: http://tyom.blogspot.com/