From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NJlSj-0000c6-JJ for qemu-devel@nongnu.org; Sun, 13 Dec 2009 05:14:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NJlSe-0000ZW-4t for qemu-devel@nongnu.org; Sun, 13 Dec 2009 05:14:00 -0500 Received: from [199.232.76.173] (port=48293 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NJlSd-0000ZO-SA for qemu-devel@nongnu.org; Sun, 13 Dec 2009 05:13:55 -0500 Received: from mail-yx0-f188.google.com ([209.85.210.188]:32823) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NJlSd-0004z8-Gm for qemu-devel@nongnu.org; Sun, 13 Dec 2009 05:13:55 -0500 Received: by yxe26 with SMTP id 26so2123303yxe.4 for ; Sun, 13 Dec 2009 02:13:53 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1260645862-13701-1-git-send-email-atar4qemu@google.com> From: Artyom Tarasenko Date: Sun, 13 Dec 2009 11:13:33 +0100 Message-ID: Content-Type: text/plain; charset=ISO-8859-1 Subject: [Qemu-devel] Re: [FOR 0.12 PATCH] scsi-disk: Inquiry with allocation length of CDB < 36 (v3) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel 2009/12/13 Blue Swirl : > On Sat, Dec 12, 2009 at 7:24 PM, Artyom Tarasenko > wrote: >> According to the SCSI-2 specification, >> http://ldkelley.com/SCSI2/SCSI2/SCSI2/SCSI2-08.html#8.2.5 , >> "if the allocation length of the command descriptor block (CDB) is too >> small to transfer all of the parameters, the additional length shall >> not be adjusted to reflect the truncation." >> The 36 mandatory bytes of response are written to outbuf, and then >> only the length requested in CDB is transferred. >> --- >> Signed-off-by: Artyom Tarasenko > > Please leave out "---" between body and SoB in the future, now the SoB > is automagically dropped by git-am. Thanks, still learning how to use git send. > The patch applies cleanly, but: /src/qemu/hw/scsi-disk.c:441: error: 'len' undeclared Arrgh. Instead of v3 I just re-submitted the old patch which was white-space damaged before (back then there was a variable "len"). Let's consider it being a test for sending patches via git send. I'll wear brown paperbag for the next two days. -- Regards, Artyom Tarasenko solaris/sparc under qemu blog: http://tyom.blogspot.com/