From: Artyom Tarasenko <atar4qemu@googlemail.com>
To: qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] [sparc32] do_unassigned_access vs. cpu_sparc_handle_mmu_fault
Date: Wed, 16 Dec 2009 20:11:48 +0100 [thread overview]
Message-ID: <fb8d4f70912161111v4b64e017q3ba10b56a9d74356@mail.gmail.com> (raw)
The function do_unassigned_access in op_helper.c looks very similar
to the function cpu_sparc_handle_mmu_fault in helper.c and it is
called after the later one.
Why do we need to set env->mmuregs[3] and env->mmuregs[4] twice?
Setting the SFSR and SFAR in do_unassigned_access looks redundant to
me and actually the second setting env->mmuregs[3] will also set the
overflow flag and therefore produce a wrong result.
Also
env->mmuregs[4] = addr;
looks wrong because addr is definied as target_phys_addr_t, so there
is a cast to the smaller uint_32 type.
If I remove the suspicious code from do_unassigned_access I can boot
Solaris 2.6.
Shall I produce a patch for 0.12?
--
Regards,
Artyom Tarasenko
solaris/sparc under qemu blog: http://tyom.blogspot.com/
next reply other threads:[~2009-12-16 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 19:11 Artyom Tarasenko [this message]
2009-12-19 10:45 ` [Qemu-devel] Re: [sparc32] do_unassigned_access vs. cpu_sparc_handle_mmu_fault Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb8d4f70912161111v4b64e017q3ba10b56a9d74356@mail.gmail.com \
--to=atar4qemu@googlemail.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).