[Qemu-devel] [qemu-web PATCH 0/2] Fix HTML issues discovered with the W3 HTML validator

[Qemu-devel] [qemu-web PATCH 0/2] Fix HTML issues discovered with the W3 HTML validator

[Thomas Huth]

The W3 HTML validator (https://validator.w3.org/) complains about
missing "alt" attributes and a missing "</section>" tag for the
new QEMU website. Here are two patches to fix the issues.

Thomas Huth (2):
  Add missing HTML tag to close the screenshots section
  Add "alt" attributes to the img tags

 _includes/screenshot.html | 2 +-
 index.html                | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
1.8.3.1

[Qemu-devel] [qemu-web PATCH 1/2] Add missing HTML tag to close the screenshots section

[Thomas Huth]

The final "</section>" tag is missing here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 index.html | 1 +
 1 file changed, 1 insertion(+)

diff --git a/index.html b/index.html
index cf31912..ab33b8a 100644
--- a/index.html
+++ b/index.html
@@ -59,6 +59,7 @@ $('.colorbox').on("click.random-namespace", function() {
 })
 </script>
 
+			</section>
 		</div>
 		<hr>
 		<p>QEMU is a member of <a href="http://wiki.qemu-project.org/Conservancy">Software Freedom Conservancy</a>.</p>
-- 
1.8.3.1

[Qemu-devel] [qemu-web PATCH 2/2] Add "alt" attributes to the img tags

[Thomas Huth]

The "alt" attribute is mandatory for the img tags according to
the HTML standard, so we need this to get valid HTML.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 _includes/screenshot.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/_includes/screenshot.html b/_includes/screenshot.html
index 3f85791..70b0d11 100644
--- a/_includes/screenshot.html
+++ b/_includes/screenshot.html
@@ -5,5 +5,5 @@
    else %}{{screenshot.description}}{%endif %}{%
    if screenshot.author %} {{screenshot.author | markdownify | remove: '<p>' | remove: '</p>' | strip_newlines | escape}} {% endif %}{%
    if screenshot.source %} (&lt;a href=&quot;{{screenshot.source}}&quot;&gt;Source&lt;/a&gt;){%endif %}"><img
-   src="screenshots/{{screenshot.file}}"/></a>
+   src="screenshots/{{screenshot.file}}" alt="Screenshot: {{screenshot.description}}"/></a>
 {% endfor %}
-- 
1.8.3.1

Re: [Qemu-devel] [qemu-web PATCH 0/2] Fix HTML issues discovered with the W3 HTML validator

[Paolo Bonzini]

On 07/02/2017 11:23, Thomas Huth wrote:
> The W3 HTML validator (https://validator.w3.org/) complains about
> missing "alt" attributes and a missing "</section>" tag for the
> new QEMU website. Here are two patches to fix the issues.
> 
> Thomas Huth (2):
>   Add missing HTML tag to close the screenshots section
>   Add "alt" attributes to the img tags
> 
>  _includes/screenshot.html | 2 +-
>  index.html                | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 

Applied, thanks! :)

Paolo

Re: [Qemu-devel] [qemu-web PATCH 0/2] Fix HTML issues discovered with the W3 HTML validator

[Thomas Huth]

On 07.02.2017 11:40, Paolo Bonzini wrote:
> 
> 
> On 07/02/2017 11:23, Thomas Huth wrote:
>> The W3 HTML validator (https://validator.w3.org/) complains about
>> missing "alt" attributes and a missing "</section>" tag for the
>> new QEMU website. Here are two patches to fix the issues.
>>
>> Thomas Huth (2):
>>   Add missing HTML tag to close the screenshots section
>>   Add "alt" attributes to the img tags
>>
>>  _includes/screenshot.html | 2 +-
>>  index.html                | 1 +
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>
> 
> Applied, thanks! :)

There is another error reported by the validator on the blog page:

https://validator.w3.org/nu/?doc=http%3A%2F%2Fwww.qemu-project.org%2Fblog%2F

But I don't have a clue how to fix that one ... the space in the URL
should be translated to %20 - any ideas how to do that with Jekyll?

 Thomas

Re: [Qemu-devel] [qemu-web PATCH 0/2] Fix HTML issues discovered with the W3 HTML validator

[Paolo Bonzini]

On 07/02/2017 11:50, Thomas Huth wrote:
> On 07.02.2017 11:40, Paolo Bonzini wrote:
>>
>>
>> On 07/02/2017 11:23, Thomas Huth wrote:
>>> The W3 HTML validator (https://validator.w3.org/) complains about
>>> missing "alt" attributes and a missing "</section>" tag for the
>>> new QEMU website. Here are two patches to fix the issues.
>>>
>>> Thomas Huth (2):
>>>   Add missing HTML tag to close the screenshots section
>>>   Add "alt" attributes to the img tags
>>>
>>>  _includes/screenshot.html | 2 +-
>>>  index.html                | 1 +
>>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>>
>>
>> Applied, thanks! :)
> 
> There is another error reported by the validator on the blog page:
> 
> https://validator.w3.org/nu/?doc=http%3A%2F%2Fwww.qemu-project.org%2Fblog%2F
> 
> But I don't have a clue how to fix that one ... the space in the URL
> should be translated to %20 - any ideas how to do that with Jekyll?

No idea, the best would probably be to make the category page "web_site"
instead of "web site".

Paolo