From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Taylor Simpson <tsimpson@quicinc.com>
Subject: Re: [PATCH] target/hexagon/gen_tcg_funcs: Fix a typo
Date: Tue, 9 Mar 2021 21:31:49 +0100 [thread overview]
Message-ID: <fba1c87e-e89f-2d19-796c-3e2b5850fb25@vivier.eu> (raw)
In-Reply-To: <20210225181507.3624509-1-f4bug@amsat.org>
Le 25/02/2021 à 19:15, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/hexagon/gen_tcg_funcs.py | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/target/hexagon/gen_tcg_funcs.py b/target/hexagon/gen_tcg_funcs.py
> index fe4d8e57303..db9f663a778 100755
> --- a/target/hexagon/gen_tcg_funcs.py
> +++ b/target/hexagon/gen_tcg_funcs.py
> @@ -35,7 +35,7 @@ def gen_decl_ea_tcg(f, tag):
> def gen_free_ea_tcg(f):
> f.write(" tcg_temp_free(EA);\n")
>
> -def genptr_decl_pair_writeble(f, tag, regtype, regid, regno):
> +def genptr_decl_pair_writable(f, tag, regtype, regid, regno):
> regN="%s%sN" % (regtype,regid)
> f.write(" TCGv_i64 %s%sV = tcg_temp_local_new_i64();\n" % \
> (regtype, regid))
> @@ -54,7 +54,7 @@ def genptr_decl_pair_writeble(f, tag, regtype, regid, regno):
> (regN, regN))
> f.write(" }\n")
>
> -def genptr_decl_writeble(f, tag, regtype, regid, regno):
> +def genptr_decl_writable(f, tag, regtype, regid, regno):
> regN="%s%sN" % (regtype,regid)
> f.write(" TCGv %s%sV = tcg_temp_local_new();\n" % \
> (regtype, regid))
> @@ -78,12 +78,12 @@ def genptr_decl(f, tag, regtype, regid, regno):
> f.write(" const int %s = insn->regno[%d];\n" % \
> (regN, regno))
> elif (regid in {"dd", "ee", "xx", "yy"}):
> - genptr_decl_pair_writeble(f, tag, regtype, regid, regno)
> + genptr_decl_pair_writable(f, tag, regtype, regid, regno)
> elif (regid in {"s", "t", "u", "v"}):
> f.write(" TCGv %s%sV = hex_gpr[insn->regno[%d]];\n" % \
> (regtype, regid, regno))
> elif (regid in {"d", "e", "x", "y"}):
> - genptr_decl_writeble(f, tag, regtype, regid, regno)
> + genptr_decl_writable(f, tag, regtype, regid, regno)
> else:
> print("Bad register parse: ", regtype, regid)
> elif (regtype == "P"):
> @@ -91,7 +91,7 @@ def genptr_decl(f, tag, regtype, regid, regno):
> f.write(" TCGv %s%sV = hex_pred[insn->regno[%d]];\n" % \
> (regtype, regid, regno))
> elif (regid in {"d", "e", "x"}):
> - genptr_decl_writeble(f, tag, regtype, regid, regno)
> + genptr_decl_writable(f, tag, regtype, regid, regno)
> else:
> print("Bad register parse: ", regtype, regid)
> elif (regtype == "C"):
> @@ -101,14 +101,14 @@ def genptr_decl(f, tag, regtype, regid, regno):
> f.write(" const int %s = insn->regno[%d] + HEX_REG_SA0;\n" % \
> (regN, regno))
> elif (regid == "dd"):
> - genptr_decl_pair_writeble(f, tag, regtype, regid, regno)
> + genptr_decl_pair_writable(f, tag, regtype, regid, regno)
> elif (regid == "s"):
> f.write(" TCGv %s%sV = tcg_temp_local_new();\n" % \
> (regtype, regid))
> f.write(" const int %s%sN = insn->regno[%d] + HEX_REG_SA0;\n" % \
> (regtype, regid, regno))
> elif (regid == "d"):
> - genptr_decl_writeble(f, tag, regtype, regid, regno)
> + genptr_decl_writable(f, tag, regtype, regid, regno)
> else:
> print("Bad register parse: ", regtype, regid)
> elif (regtype == "M"):
>
Applied to my trivial-patches branch.
Thanks,
Laurent
prev parent reply other threads:[~2021-03-09 21:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 18:15 [PATCH] target/hexagon/gen_tcg_funcs: Fix a typo Philippe Mathieu-Daudé
2021-02-25 18:35 ` Taylor Simpson
2021-03-09 20:31 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fba1c87e-e89f-2d19-796c-3e2b5850fb25@vivier.eu \
--to=laurent@vivier.eu \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).