From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39384)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1bv3R6-0001KD-05
	for qemu-devel@nongnu.org; Fri, 14 Oct 2016 10:26:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1bv3R2-0004sE-M8
	for qemu-devel@nongnu.org; Fri, 14 Oct 2016 10:26:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33992)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1bv3R2-0004ri-F1
	for qemu-devel@nongnu.org; Fri, 14 Oct 2016 10:26:08 -0400
References: <1476375902-11715-1-git-send-email-lvivier@redhat.com>
	<1476375902-11715-2-git-send-email-lvivier@redhat.com>
	<20161014161158.16187a9a@nial.brq.redhat.com>
	<a47b1ca6-da22-28a7-d494-642377214314@redhat.com>
From: Laurent Vivier <lvivier@redhat.com>
Message-ID: <fbac03b8-a610-af00-ce45-8c89aa9a74b3@redhat.com>
Date: Fri, 14 Oct 2016 16:26:02 +0200
MIME-Version: 1.0
In-Reply-To: <a47b1ca6-da22-28a7-d494-642377214314@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 01/20] exec: split cpu_exec_init()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Matthew Rosato <mjrosato@linux.vnet.ibm.com>, Peter Maydell <peter.maydell@linaro.org>, Markus Armbruster <armbru@redhat.com>, Bharata B Rao <bharata@linux.vnet.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, David Gibson <david@gibson.dropbear.id.au>



On 14/10/2016 16:13, Laurent Vivier wrote:
> 
> 
> On 14/10/2016 16:11, Igor Mammedov wrote:
>> On Thu, 13 Oct 2016 18:24:43 +0200
>> Laurent Vivier <lvivier@redhat.com> wrote:
>>
>>> Extract the realize part to cpu_exec_realize(), update all
>>> calls to cpu_exec_init() to add cpu_exec_realize() to
>>> have no functionnal change.
>>>
>>> Put in cpu_exec_init() what initializes the CPU,
>>> in cpu_exec_realize() what adds it to the environment.
>> now since it's split, why not call cpu_exec_init()
>> from common cpu_common_initfn() and do
>> s/cpu_exec_init/cpu_exec_realize/ on individual targets
>> so that they don't have to call it from their _initfn()s.
> 
> It's done later in the series.

But I'm going to simplified the series as proposed by you and Eduardo.

Thanks,
Laurent