From: Eric Blake <eblake@redhat.com>
To: Stefan Weil <sw@weilnetz.de>,
Andrew Baumann <Andrew.Baumann@microsoft.com>,
qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v3 for-2.9?] virtio: fix vring_align() on 64-bit windows
Date: Tue, 28 Mar 2017 13:51:57 -0500 [thread overview]
Message-ID: <fbb1c7da-1c51-8ee5-b94d-62fd17c068e0@redhat.com> (raw)
In-Reply-To: <bb0868d1-5c56-45e5-8b6c-ee08e77dfeaa@weilnetz.de>
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
On 03/28/2017 01:38 PM, Stefan Weil wrote:
> Am 25.03.2017 um 00:19 schrieb Andrew Baumann:
>> long is 32-bits on 64-bit windows, which caused the top half of the
>> address to be truncated; this patch changes it to use the
>> QEMU_ALIGN_UP macro which does not suffer the same problem
>>
>> Signed-off-by: Andrew Baumann <Andrew.Baumann@microsoft.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> ---
> Eric added "for-2.9" to the subject line of v2, but now it was
> missing again for v3.
>
> Is this needed for 2.9?
Yes, it's a correctness bug that avoids miscompilation on 64-bit targets
where long is 32 bits (which, at the moment, is really just Windows).
> I wonder why I never before noticed
> a problem or got a bug report for this issue.
Probably because so few people are testing on native Windows, and it
doesn't affect other platforms.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-03-28 18:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 23:19 [Qemu-devel] [PATCH v3] virtio: fix vring_align() on 64-bit windows Andrew Baumann
2017-03-28 18:38 ` [Qemu-devel] [PATCH v3 for-2.9?] " Stefan Weil
2017-03-28 18:51 ` Eric Blake [this message]
2017-03-28 18:56 ` Andrew Baumann
2017-03-28 19:25 ` Stefan Weil
2017-03-28 20:02 ` [Qemu-devel] [PATCH v3 for-2.9] " Stefan Weil
2017-03-28 20:11 ` Michael S. Tsirkin
2017-03-28 20:19 ` Stefan Weil
2017-03-28 19:12 ` [Qemu-devel] [PATCH v3 for-2.9?] " Philippe Mathieu-Daudé
2017-03-28 20:09 ` [Qemu-devel] [PATCH v3] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbb1c7da-1c51-8ee5-b94d-62fd17c068e0@redhat.com \
--to=eblake@redhat.com \
--cc=Andrew.Baumann@microsoft.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).