From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] doc: Describe missing generic -blockdev options
Date: Tue, 15 Oct 2019 08:59:06 -0500 [thread overview]
Message-ID: <fbbf6bad-4434-4150-1053-a1b790d71a3c@redhat.com> (raw)
In-Reply-To: <20191015123854.12039-1-kwolf@redhat.com>
On 10/15/19 7:38 AM, Kevin Wolf wrote:
> We added more generic options after introducing -blockdev and forgot to
> update the documentation (man page and --help output) accordingly. Do
> that now.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qemu-options.hx | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> @@ -885,6 +886,22 @@ name is not intended to be predictable and changes between QEMU invocations.
> For the top level, an explicit node name must be specified.
> @item read-only
> Open the node read-only. Guest write attempts will fail.
> +
> +Note that some block drivers support only read-only access, either generally or
> +in certain configurations. In this case, the default value
> +@option{read-only=off} does not work and the option must be specified
> +explicitly.
> +@item auto-read-only
> +If @option{auto-read-only=on} is set, QEMU is allowed not to open the image
> +read-write even if @option{read-only=off} is requested, but fall back to
> +read-only instead (and switch between the modes later), e.g. depending on
> +whether the image file is writable or whether a writing user is attached to the
> +node.
Hard to read. Maybe:
If @option{auto-read-only=on} is set, QEMU may fall back to read-only
usage even when @option{read-only=off} is requested, or even switch
between modes as needed, e.g. depending on whether the image file is
writable or whether a writing user is attached to the node.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2019-10-15 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 12:38 [PATCH] doc: Describe missing generic -blockdev options Kevin Wolf
2019-10-15 13:55 ` Peter Maydell
2019-10-15 14:05 ` Kevin Wolf
2019-10-15 14:17 ` Eric Blake
2019-10-15 13:59 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbbf6bad-4434-4150-1053-a1b790d71a3c@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).