From: Jeuk Kim <jeuk20.kim@gmail.com>
To: Minwoo Im <minwoo.im.dev@gmail.com>, Jeuk Kim <jeuk20.kim@samsung.com>
Cc: qemu-devel@nongnu.org, Minwoo Im <minwoo.im@samsung.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] hw/ufs: Fix potential bugs in MMIO read|write
Date: Mon, 24 Jun 2024 19:14:59 +0900 [thread overview]
Message-ID: <fbc0a8cd-8b29-4cb0-8ea6-c7fb34f52c18@gmail.com> (raw)
In-Reply-To: <20240623024555.78697-1-minwoo.im.dev@gmail.com>
On 6/23/2024 11:45 AM, Minwoo Im wrote:
> This patch fixes two points reported in coverity scan report [1]. Check
> the MMIO access address with (addr + size), not just with the start offset
> addr to make sure that the requested memory access not to exceed the
> actual register region. We also updated (uint8_t *) to (uint32_t *) to
> represent we are accessing the MMIO registers by dword-sized only.
>
> [1] https://lore.kernel.org/qemu-devel/CAFEAcA82L-WZnHMW0X+Dr40bHM-EVq2ZH4DG4pdqop4xxDP2Og@mail.gmail.com/
>
> Cc: Jeuk Kim <jeuk20.kim@gmail.com>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
Thank you for the patch.
Reviewed-by: Jeuk Kim <jeuk20.kim@samsung.com>
next prev parent reply other threads:[~2024-06-24 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 2:45 [PATCH] hw/ufs: Fix potential bugs in MMIO read|write Minwoo Im
2024-06-24 10:14 ` Jeuk Kim [this message]
2024-06-24 10:27 ` Peter Maydell
2024-06-24 11:54 ` Jeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbc0a8cd-8b29-4cb0-8ea6-c7fb34f52c18@gmail.com \
--to=jeuk20.kim@gmail.com \
--cc=jeuk20.kim@samsung.com \
--cc=minwoo.im.dev@gmail.com \
--cc=minwoo.im@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).