From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>, QEMU <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Berger <stefanb@linux.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 0/8] tpm: Split hw/ vs backends/
Date: Wed, 10 Jun 2020 22:13:26 +0200 [thread overview]
Message-ID: <fbc1d5ea-4097-81b4-3e09-1820d112d78d@redhat.com> (raw)
In-Reply-To: <CAJ+F1CLwLqTCKbUw_xrVax1zctE3Q68ZbaM_Tydn7ZqELp8vnw@mail.gmail.com>
On 6/10/20 10:09 PM, Marc-André Lureau wrote:
> Hi
>
> On Thu, Jun 11, 2020 at 12:03 AM Philippe Mathieu-Daudé
> <philmd@redhat.com <mailto:philmd@redhat.com>> wrote:
>
> Hi,
>
> Today I started to review some vTPM patches and got very
> confused by the files under hw/tpm/. In particular after
> running:
>
> $ git grep TYPE_TPM_BACKEND
> backends/tpm.c:188: .name = TYPE_TPM_BACKEND,
> hw/tpm/tpm_emulator.c:985: .parent = TYPE_TPM_BACKEND,
> hw/tpm/tpm_passthrough.c:393: .parent = TYPE_TPM_BACKEND,
> include/sysemu/tpm_backend.h:21:#define TYPE_TPM_BACKEND "tpm-backend"
>
> As there is no particular reason to keep this mixed, clean it up.
>
>
> While at it, why not start to organize backends/ ? I would move that
> under backends/tpm/
Sure, if the overall of this series looks good, I can do that.
I'll wait for positive/negative feedback first.
>
>
> Philippe Mathieu-Daudé (8):
> hw/tpm: Do not include 'qemu/osdep.h' in header
> hw/tpm: Include missing 'qemu/option.h' header
> hw/tpm: Move 'hw/acpi/tpm.h' inclusion from header to sources
> hw/tpm: Remove unnecessary 'tpm_int.h' header inclusion
> hw/tpm: Move few declarations from 'tpm_util.h' to 'tpm_int.h'
> hw/tpm: Move DEFINE_PROP_TPMBE() macro to 'tmp_prop.h' local header
> hw/tpm: Make 'tpm_util.h' publicly accessible as "sysemu/tpm_util.h"
> tpm: Move backend code under the 'backends/' directory
>
> Makefile | 2 +-
> {hw/tpm => backends}/tpm_int.h | 19 +++++++++++---
> {hw/tpm => backends}/tpm_ioctl.h | 0
> hw/tpm/tpm_ppi.h | 1 -
> hw/tpm/tpm_prop.h | 31 +++++++++++++++++++++++
> hw/tpm/tpm_tis.h | 1 -
> {hw/tpm => include/sysemu}/tpm_util.h | 19 +++-----------
> {hw/tpm => backends}/tpm_emulator.c | 2 +-
> {hw/tpm => backends}/tpm_passthrough.c | 2 +-
> {hw/tpm => backends}/tpm_util.c | 2 +-
> hw/tpm/tpm_crb.c | 4 +--
> hw/tpm/tpm_spapr.c | 4 +--
> hw/tpm/tpm_tis_common.c | 4 +--
> hw/tpm/tpm_tis_isa.c | 3 ++-
> hw/tpm/tpm_tis_sysbus.c | 3 ++-
> tests/qtest/tpm-emu.c | 2 +-
> MAINTAINERS | 2 +-
> backends/Kconfig | 14 +++++++++++
> backends/Makefile.objs | 3 +++
> backends/trace-events | 32 ++++++++++++++++++++++++
> hw/tpm/Kconfig | 15 ------------
> hw/tpm/Makefile.objs | 3 ---
> hw/tpm/trace-events | 34 +-------------------------
> 23 files changed, 116 insertions(+), 86 deletions(-)
> rename {hw/tpm => backends}/tpm_int.h (81%)
> rename {hw/tpm => backends}/tpm_ioctl.h (100%)
> create mode 100644 hw/tpm/tpm_prop.h
> rename {hw/tpm => include/sysemu}/tpm_util.h (80%)
> rename {hw/tpm => backends}/tpm_emulator.c (99%)
> rename {hw/tpm => backends}/tpm_passthrough.c (99%)
> rename {hw/tpm => backends}/tpm_util.c (99%)
> create mode 100644 backends/Kconfig
>
> --
> 2.21.3
>
>
>
>
> --
> Marc-André Lureau
next prev parent reply other threads:[~2020-06-10 20:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 20:02 [PATCH 0/8] tpm: Split hw/ vs backends/ Philippe Mathieu-Daudé
2020-06-10 20:02 ` [PATCH 1/8] hw/tpm: Do not include 'qemu/osdep.h' in header Philippe Mathieu-Daudé
2020-06-11 11:55 ` Stefan Berger
2020-06-10 20:02 ` [PATCH 2/8] hw/tpm: Include missing 'qemu/option.h' header Philippe Mathieu-Daudé
2020-06-11 11:55 ` Stefan Berger
2020-06-10 20:02 ` [PATCH 3/8] hw/tpm: Move 'hw/acpi/tpm.h' inclusion from header to sources Philippe Mathieu-Daudé
2020-06-11 11:55 ` Stefan Berger
2020-06-10 20:02 ` [PATCH 4/8] hw/tpm: Remove unnecessary 'tpm_int.h' header inclusion Philippe Mathieu-Daudé
2020-06-11 11:56 ` Stefan Berger
2020-06-10 20:02 ` [PATCH 5/8] hw/tpm: Move few declarations from 'tpm_util.h' to 'tpm_int.h' Philippe Mathieu-Daudé
2020-06-11 11:56 ` Stefan Berger
2020-06-10 20:02 ` [PATCH 6/8] hw/tpm: Move DEFINE_PROP_TPMBE() macro to 'tmp_prop.h' local header Philippe Mathieu-Daudé
2020-06-11 11:57 ` Stefan Berger
2020-06-10 20:02 ` [PATCH 7/8] hw/tpm: Make 'tpm_util.h' publicly accessible as "sysemu/tpm_util.h" Philippe Mathieu-Daudé
2020-06-11 11:57 ` Stefan Berger
2020-06-10 20:02 ` [RFC PATCH 8/8] tpm: Move backend code under the 'backends/' directory Philippe Mathieu-Daudé
2020-06-11 12:00 ` Stefan Berger
2020-06-11 12:05 ` Thomas Huth
2020-06-11 12:21 ` Stefan Berger
2020-06-10 20:09 ` [PATCH 0/8] tpm: Split hw/ vs backends/ Marc-André Lureau
2020-06-10 20:13 ` Philippe Mathieu-Daudé [this message]
2020-06-10 20:12 ` Philippe Mathieu-Daudé
2020-06-10 21:26 ` no-reply
2020-06-10 21:31 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbc1d5ea-4097-81b4-3e09-1820d112d78d@redhat.com \
--to=philmd@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).