From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACEB8C64ED8 for ; Fri, 24 Feb 2023 08:09:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVT9A-0008CX-16; Fri, 24 Feb 2023 03:09:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVT8v-00086f-4T for qemu-devel@nongnu.org; Fri, 24 Feb 2023 03:09:25 -0500 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVT8s-00050q-Ty for qemu-devel@nongnu.org; Fri, 24 Feb 2023 03:09:24 -0500 Received: by mail-pf1-x42a.google.com with SMTP id a7so7583696pfx.10 for ; Fri, 24 Feb 2023 00:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cmDvXOrVH6Soh/WgBp9eT1D+C92w7+ZalDrdbloEXwE=; b=eYHFjVD8omfvzzWstSJp/KtQNyfl47yWTpmvP+Gh2Nwsbd1y3+sbMRNCl7K8o0bY8s rEUwD3VW96D9Qp6P8YikA8GudT1DZwpatY/h47krr01/2rOX7MIC+vOLD+lR7wTIJ/1O v0J9J79HMmX8fFu66PQaUhQJPYUFLmFrmp4xgtZlEKyQkmZ4k8Oze26QBPvdD6bkrb+v PTNkXdUGfMAIiME2TO8RYkNYogpAY8boDsjx3dmFYxmhB1qNprJJFkLQnL8Ot8MPYjSR MvQCoTPlsrSfJ993rzeXNJMz/gOMSXJ49SROnM4ce98D8CBgG4mFIg2uE37XuNG06IVD /Jgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cmDvXOrVH6Soh/WgBp9eT1D+C92w7+ZalDrdbloEXwE=; b=Um9zyVK47Drju9/oO5/ASiyuc8e70hMR/dTv39aJkTOGu+sPFRSzfu9uff9MjVKU2F wNQj4wHEnngkcvMtLH0qXqXj3AD6aYSraRsClKQ7QVtQ4hPE9i5JEtqM6r1r88x7KT2X vEcUss3d5KhHyB3vV6+vX87/z5tcbkAKkVM8jaARmBoakK/lPQc3xX//4+T5EzgeQ50L Jx4CxP2FYShC51WIcD6bqIK+sTVi6VcfMRZSjONLp4b4MMkCX9/Ss5jDFGhheOY7xK8a GRrAFFwYaRQGLOoOnvy4sBCvQU0s4rWXTqyGgJQGCd3brbRcPNM403PSn/Xndb/82W/+ KoTg== X-Gm-Message-State: AO0yUKU2CXV7nkt5KfhNiEkauIy2H4zmOkiAEHV50jVj1goYBrkCLymE ZWaEJwXY7wYHdfI98G9wjFo9hg== X-Google-Smtp-Source: AK7set83LcTtSM9zSxLKNB53XSTwTvjKn6jM1rFimaoxF1cVyF6eWpvmTkQQfr2WIF6Z+5JW/IN2WQ== X-Received: by 2002:a62:6456:0:b0:5a8:b2bf:26ac with SMTP id y83-20020a626456000000b005a8b2bf26acmr14716591pfb.20.1677226160749; Fri, 24 Feb 2023 00:09:20 -0800 (PST) Received: from [192.168.6.128] (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id x47-20020a056a000bef00b005ae02dc6285sm8018178pfu.203.2023.02.24.00.09.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 00:09:20 -0800 (PST) Message-ID: Date: Thu, 23 Feb 2023 22:09:17 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] accel/tcg: Add 'size' param to probe_access_full Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: dbarboza@ventanamicro.com References: <20230224004558.1313614-1-richard.henderson@linaro.org> <6517a169-07b0-6ee2-1492-95d6d5c82ecc@linaro.org> From: Richard Henderson In-Reply-To: <6517a169-07b0-6ee2-1492-95d6d5c82ecc@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42a.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.09, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/23/23 20:57, Philippe Mathieu-Daudé wrote: > On 24/2/23 01:45, Richard Henderson wrote: >> Change to match the recent change to probe_access_flags. >> All existing callers updated to supply 0, so no change in behaviour. >> >> Signed-off-by: Richard Henderson >> --- >>   include/exec/exec-all.h              | 2 +- >>   accel/tcg/cputlb.c                   | 4 ++-- >>   target/arm/mte_helper.c              | 4 ++-- >>   target/arm/ptw.c                     | 2 +- >>   target/arm/sve_helper.c              | 2 +- >>   target/arm/translate-a64.c           | 2 +- >>   target/i386/tcg/sysemu/excp_helper.c | 4 ++-- >>   7 files changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h >> index 165b050872..b631832e17 100644 >> --- a/include/exec/exec-all.h >> +++ b/include/exec/exec-all.h >> @@ -475,7 +475,7 @@ int probe_access_flags(CPUArchState *env, target_ulong addr, int size, >>    * and must be consumed or copied immediately, before any further >>    * access or changes to TLB @mmu_idx. >>    */ >> -int probe_access_full(CPUArchState *env, target_ulong addr, >> +int probe_access_full(CPUArchState *env, target_ulong addr, int size, >>                         MMUAccessType access_type, int mmu_idx, >>                         bool nonfault, void **phost, >>                         CPUTLBEntryFull **pfull, uintptr_t retaddr); > > Why is 'size' signed? (similar in probe_access_flags). Not sure. But all of the other interfaces exposed are signed too. r~