From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: stefanha@redhat.com, hreitz@redhat.com, eblake@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 11/11] Revert "graph-lock: Disable locking for now"
Date: Mon, 5 Jun 2023 11:06:23 +0200 [thread overview]
Message-ID: <fbcb21e3-9544-eea2-ab5b-9bb84ac7c90b@redhat.com> (raw)
In-Reply-To: <20230605085711.21261-12-kwolf@redhat.com>
On 6/5/23 10:57, Kevin Wolf wrote:
> void bdrv_graph_rdlock_main_loop(void)
> @@ -296,18 +276,13 @@ void assert_bdrv_graph_readable(void)
> {
> /* reader_count() is slow due to aio_context_list_lock lock contention */
> /* TODO Reenable when wrlock is reenabled */
There's still a TODO here.
Paolo
> -#if 0
> #ifdef CONFIG_DEBUG_GRAPH_LOCK
> assert(qemu_in_main_thread() || reader_count());
> #endif
> -#endif
> }
next prev parent reply other threads:[~2023-06-05 9:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 8:57 [PATCH v2 00/11] block: Re-enable the graph lock Kevin Wolf
2023-06-05 8:57 ` [PATCH v2 01/11] iotests: Test active commit with iothread and background I/O Kevin Wolf
2023-06-05 8:57 ` [PATCH v2 02/11] qdev-properties-system: Lock AioContext for blk_insert_bs() Kevin Wolf
2023-06-05 8:57 ` [PATCH v2 03/11] test-block-iothread: " Kevin Wolf
2023-06-05 8:57 ` [PATCH v2 04/11] block: Fix AioContext locking in bdrv_open_child() Kevin Wolf
2023-06-05 8:57 ` [PATCH v2 05/11] block: Fix AioContext locking in bdrv_attach_child_common() Kevin Wolf
2023-06-05 8:57 ` [PATCH v2 06/11] block: Fix AioContext locking in bdrv_reopen_parse_file_or_backing() Kevin Wolf
2023-06-05 8:57 ` [PATCH v2 07/11] block: Fix AioContext locking in bdrv_open_inherit() Kevin Wolf
2023-06-05 8:57 ` [PATCH v2 08/11] block: Fix AioContext locking in bdrv_open_backing_file() Kevin Wolf
2023-06-05 8:57 ` [PATCH v2 09/11] blockjob: Fix AioContext locking in block_job_add_bdrv() Kevin Wolf
2023-06-05 8:57 ` [PATCH v2 10/11] graph-lock: Unlock the AioContext while polling Kevin Wolf
2023-06-05 8:57 ` [PATCH v2 11/11] Revert "graph-lock: Disable locking for now" Kevin Wolf
2023-06-05 9:06 ` Paolo Bonzini [this message]
2023-06-05 10:03 ` Kevin Wolf
2023-06-07 18:19 ` [PATCH v2 00/11] block: Re-enable the graph lock Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbcb21e3-9544-eea2-ab5b-9bb84ac7c90b@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).