From: Richard Henderson <richard.henderson@linaro.org>
To: Fabiano Rosas <farosas@linux.ibm.com>, qemu-devel@nongnu.org
Cc: danielhb413@gmail.com, qemu-ppc@nongnu.org, clg@kaod.org,
david@gibson.dropbear.id.au
Subject: Re: [PATCH v2 3/5] target/ppc: powerpc_excp: Set vector earlier
Date: Thu, 30 Dec 2021 14:05:57 -0800 [thread overview]
Message-ID: <fbd28e4a-01fa-c96b-5a27-cd14e82f8c5d@linaro.org> (raw)
In-Reply-To: <20211229165751.3774248-4-farosas@linux.ibm.com>
On 12/29/21 8:57 AM, Fabiano Rosas wrote:
> None of the interrupt setup code touches 'vector', so we can move it
> earlier in the function. This will allow us to later move the System
> Call Vectored setup that is on the top level into the
> POWERPC_EXCP_SYSCALL_VECTORED code block.
>
> This patch also moves the verification for when 'excp' does not have
> an address associated with it. We now bail a little earlier when that
> is the case. This should not cause any visible effects.
>
> Signed-off-by: Fabiano Rosas<farosas@linux.ibm.com>
> Reviewed-by: Cédric Le Goater<clg@kaod.org>
> ---
> target/ppc/excp_helper.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-12-30 22:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 16:57 [PATCH v2 0/5] target/ppc: powerpc_excp improvements (1/n) Fabiano Rosas
2021-12-29 16:57 ` [PATCH v2 1/5] target/ppc: powerpc_excp: Set alternate SRRs directly Fabiano Rosas
2021-12-29 16:57 ` [PATCH v2 2/5] target/ppc: powerpc_excp: Add excp_vectors bounds check Fabiano Rosas
2021-12-30 22:04 ` Richard Henderson
2021-12-31 7:40 ` Cédric Le Goater
2022-01-01 8:29 ` David Gibson
2021-12-29 16:57 ` [PATCH v2 3/5] target/ppc: powerpc_excp: Set vector earlier Fabiano Rosas
2021-12-30 22:05 ` Richard Henderson [this message]
2022-01-01 8:31 ` David Gibson
2021-12-29 16:57 ` [PATCH v2 4/5] target/ppc: powerpc_excp: Move system call vectored code together Fabiano Rosas
2021-12-29 16:57 ` [PATCH v2 5/5] target/ppc: powerpc_excp: Stop passing excp_model around Fabiano Rosas
2022-01-04 7:40 ` [PATCH v2 0/5] target/ppc: powerpc_excp improvements (1/n) Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbd28e4a-01fa-c96b-5a27-cd14e82f8c5d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).