From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL 0/8] NBD patches through 2020-10-08
Date: Fri, 9 Oct 2020 07:25:53 -0500 [thread overview]
Message-ID: <fbd990fb-e32c-c0c6-b993-876ce7ae757f@redhat.com> (raw)
In-Reply-To: <CAFEAcA-EO9C+JsH_J+teH9RPFM17OVaYY4x=OF6wnC-d-YwSog@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 770 bytes --]
On 10/9/20 7:16 AM, Peter Maydell wrote:
>> ----------------------------------------------------------------
>> nbd patches for 2020-10-08
>>
>> - silence compilation warnings
>> - more fixes to prevent reconnect hangs
>> - improve 'qemu-nbd' termination behavior
>> - cleaner NBD protocol compliance on string handling
>
> Build failure, OSX, FreeBSD, NetBSD:
>
> Linking static target libqemuutil.a
> ../../qemu-nbd.c:591:29: error: use of undeclared identifier 'termsig_handler'
> sa_sigterm.sa_handler = termsig_handler;
> ^
I see it; inconsistent #ifdefs. Will spin v2 shortly.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-10-09 12:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 18:59 [PULL 0/8] NBD patches through 2020-10-08 Eric Blake
2020-10-08 18:59 ` [PULL 1/8] nbd: silence maybe-uninitialized warnings Eric Blake
2020-10-08 18:59 ` [PULL 2/8] block/nbd: fix drain dead-lock because of nbd reconnect-delay Eric Blake
2020-10-08 18:59 ` [PULL 3/8] block/nbd: correctly use qio_channel_detach_aio_context when needed Eric Blake
2020-10-08 18:59 ` [PULL 4/8] block/nbd: fix reconnect-delay Eric Blake
2020-10-08 18:59 ` [PULL 5/8] block/nbd: nbd_co_reconnect_loop(): don't connect if drained Eric Blake
2020-10-08 18:59 ` [PULL 6/8] qemu-nbd: Honor SIGINT and SIGHUP Eric Blake
2020-10-08 18:59 ` [PULL 7/8] nbd/server: Reject embedded NUL in NBD strings Eric Blake
2020-10-08 18:59 ` [PULL 8/8] nbd: Simplify meta-context parsing Eric Blake
2020-10-09 12:16 ` [PULL 0/8] NBD patches through 2020-10-08 Peter Maydell
2020-10-09 12:25 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbd990fb-e32c-c0c6-b993-876ce7ae757f@redhat.com \
--to=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).