* [PATCH] target/arm: Copy the entire vector in DO_ZIP
@ 2022-10-31 5:41 Richard Henderson
2022-10-31 8:16 ` Philippe Mathieu-Daudé
2022-10-31 13:45 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Richard Henderson @ 2022-10-31 5:41 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm, Idan Horowitz
With odd_ofs set, we weren't copying enough data.
Fixes: 09eb6d7025d1 ("target/arm: Move sve zip high_ofs into simd_data")
Reported-by: Idan Horowitz <idan.horowitz@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/sve_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c
index 3d0d2987cd..1afeadf9c8 100644
--- a/target/arm/sve_helper.c
+++ b/target/arm/sve_helper.c
@@ -3366,10 +3366,10 @@ void HELPER(NAME)(void *vd, void *vn, void *vm, uint32_t desc) \
/* We produce output faster than we consume input. \
Therefore we must be mindful of possible overlap. */ \
if (unlikely((vn - vd) < (uintptr_t)oprsz)) { \
- vn = memcpy(&tmp_n, vn, oprsz_2); \
+ vn = memcpy(&tmp_n, vn, oprsz); \
} \
if (unlikely((vm - vd) < (uintptr_t)oprsz)) { \
- vm = memcpy(&tmp_m, vm, oprsz_2); \
+ vm = memcpy(&tmp_m, vm, oprsz); \
} \
for (i = 0; i < oprsz_2; i += sizeof(TYPE)) { \
*(TYPE *)(vd + H(2 * i + 0)) = *(TYPE *)(vn + odd_ofs + H(i)); \
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] target/arm: Copy the entire vector in DO_ZIP
2022-10-31 5:41 [PATCH] target/arm: Copy the entire vector in DO_ZIP Richard Henderson
@ 2022-10-31 8:16 ` Philippe Mathieu-Daudé
2022-10-31 13:45 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-10-31 8:16 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: qemu-arm, Idan Horowitz
On 31/10/22 06:41, Richard Henderson wrote:
> With odd_ofs set, we weren't copying enough data.
>
> Fixes: 09eb6d7025d1 ("target/arm: Move sve zip high_ofs into simd_data")
> Reported-by: Idan Horowitz <idan.horowitz@gmail.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/sve_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/arm: Copy the entire vector in DO_ZIP
2022-10-31 5:41 [PATCH] target/arm: Copy the entire vector in DO_ZIP Richard Henderson
2022-10-31 8:16 ` Philippe Mathieu-Daudé
@ 2022-10-31 13:45 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2022-10-31 13:45 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, qemu-arm, Idan Horowitz
On Mon, 31 Oct 2022 at 05:42, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> With odd_ofs set, we weren't copying enough data.
>
> Fixes: 09eb6d7025d1 ("target/arm: Move sve zip high_ofs into simd_data")
> Reported-by: Idan Horowitz <idan.horowitz@gmail.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-31 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-31 5:41 [PATCH] target/arm: Copy the entire vector in DO_ZIP Richard Henderson
2022-10-31 8:16 ` Philippe Mathieu-Daudé
2022-10-31 13:45 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).