From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxd5f-0006r5-EO for qemu-devel@nongnu.org; Mon, 10 Apr 2017 13:27:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxd5e-0003Lk-Fh for qemu-devel@nongnu.org; Mon, 10 Apr 2017 13:26:59 -0400 Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:35807) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cxd5e-0003LD-AB for qemu-devel@nongnu.org; Mon, 10 Apr 2017 13:26:58 -0400 Received: by mail-pg0-x243.google.com with SMTP id g2so26430828pge.2 for ; Mon, 10 Apr 2017 10:26:56 -0700 (PDT) Sender: Richard Henderson References: <20170410060655.32289-1-nikunj@linux.vnet.ibm.com> From: Richard Henderson Message-ID: Date: Mon, 10 Apr 2017 10:26:52 -0700 MIME-Version: 1.0 In-Reply-To: <20170410060655.32289-1-nikunj@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH fix for-2.9] cpus: fix wrong define name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania , qemu-devel@nongnu.org, peter.maydell@linaro.org Cc: pbonzini@redhat.com, crosthwaite.peter@gmail.com, david@gibson.dropbear.id.au, alex.bennee@linaro.org On 04/09/2017 11:06 PM, Nikunj A Dadhania wrote: > While the configure script generates TARGET_SUPPORTS_MTTCG define, one > of the define is cpus.c is checking wrong name: TARGET_SUPPORT_MTTCG > > Signed-off-by: Nikunj A Dadhania > --- > cpus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cpus.c b/cpus.c > index 68fdbc4..58d90aa 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -202,7 +202,7 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp) > } else if (use_icount) { > error_setg(errp, "No MTTCG when icount is enabled"); > } else { > -#ifndef TARGET_SUPPORT_MTTCG > +#ifndef TARGET_SUPPORTS_MTTCG This sort of thing is why glibc moved to using -Wundef. It would be a huge amount of work to convert our existing sources, but it would probably pay off in the long run. r~