From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: John Arbuckle <programmingkidx@gmail.com>,
Roman Bolshakov <r.bolshakov@yadro.com>,
Berkus Decker <berkus@gmail.com>,
Gerd Hoffmann <kraxel@redhat.com>,
patches@linaro.org
Subject: Re: [Qemu-devel] [RFC 0/5] ui/cocoa: Use OSX's main loop
Date: Mon, 3 Dec 2018 09:47:15 -0600 [thread overview]
Message-ID: <fc1c6621-ed1a-d53f-0b79-08fbab57205d@linaro.org> (raw)
In-Reply-To: <20181201123056.432-1-peter.maydell@linaro.org>
On 12/1/18 6:30 AM, Peter Maydell wrote:
> Patchset structure:
> * patch 1 does the "make sure we have the iothread lock for
> calls into QEMU" (which is effectively a no-op initially
> since we'll already be holding that lock when our refresh
> etc callbacks are called)
> * patch 2 makes switchSurface directly take the pixman image
> (which is refcounted) rather than the DisplaySurface (which
> is not), so we can make the calls to it asynchronous later
> * patches 3 and 4 are just trivial code motion
> * patch 5 does the bulk of the work (and can't really be split
> further without the UI being broken at the intermediate point)
FWIW, this makes sense and is relatively easy to follow.
That said, I've never touched OSX at all, so can't even test.
r~
next prev parent reply other threads:[~2018-12-03 15:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 12:30 [Qemu-devel] [RFC 0/5] ui/cocoa: Use OSX's main loop Peter Maydell
2018-12-01 12:30 ` [Qemu-devel] [RFC 1/5] ui/cocoa: Ensure we have the iothread lock when calling into QEMU Peter Maydell
2018-12-01 12:30 ` [Qemu-devel] [RFC 2/5] ui/cocoa: Use the pixman image directly in switchSurface Peter Maydell
2018-12-01 12:30 ` [Qemu-devel] [RFC 3/5] ui/cocoa: Factor out initial menu creation Peter Maydell
2018-12-01 12:30 ` [Qemu-devel] [RFC 4/5] ui/cocoa: Move console/device menu creation code up in file Peter Maydell
2018-12-01 12:30 ` [Qemu-devel] [RFC 5/5] ui/cocoa: Perform UI operations only on the main thread Peter Maydell
2018-12-03 15:47 ` Richard Henderson [this message]
2018-12-05 6:51 ` [Qemu-devel] [RFC 0/5] ui/cocoa: Use OSX's main loop Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc1c6621-ed1a-d53f-0b79-08fbab57205d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berkus@gmail.com \
--cc=kraxel@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).