qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	Stefan Weil <sw@weilnetz.de>
Subject: Re: [PATCH v2 3/4] configure: Improve TCI feature description
Date: Fri, 22 Jan 2021 12:32:56 +0100	[thread overview]
Message-ID: <fc2847c8-d897-aad1-0b00-1f6b3b1211a2@redhat.com> (raw)
In-Reply-To: <20210122105836.1878506-4-philmd@redhat.com>

On 22/01/2021 11.58, Philippe Mathieu-Daudé wrote:
> Users might want to enable all features, without realizing some
> features have negative effect. Mention the TCI feature is slow
> and experimental, hoping it will be selected knowingly.
> 
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 9f016b06b54..71bdc523aa0 100755
> --- a/configure
> +++ b/configure
> @@ -1753,7 +1753,7 @@ Advanced options (experts only):
>     --with-trace-file=NAME   Full PATH,NAME of file to store traces
>                              Default:trace-<pid>
>     --disable-slirp          disable SLIRP userspace network connectivity
> -  --enable-tcg-interpreter enable TCG with bytecode interpreter (TCI)
> +  --enable-tcg-interpreter enable TCG with bytecode interpreter (experimental and slow)

I'd prefer if we could keep the "TCI" in there ... I remember having grep'ed 
for "tci" in the help output in the past, so I think it would be good to 
keep the TLA here. Maybe just put "TCI, slow" in the parantheses and omit 
"experimental"?

  Thomas



  reply	other threads:[~2021-01-22 11:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 10:58 [PATCH v2 0/4] meson: Try to clarify TCG / TCI options for new users Philippe Mathieu-Daudé
2021-01-22 10:58 ` [PATCH v2 1/4] meson: Explicit TCG backend used Philippe Mathieu-Daudé
2021-01-22 10:58 ` [PATCH v2 2/4] meson: Warn when TCI is selected but TCG backend is available Philippe Mathieu-Daudé
2021-01-22 10:58 ` [PATCH v2 3/4] configure: Improve TCI feature description Philippe Mathieu-Daudé
2021-01-22 11:32   ` Thomas Huth [this message]
2021-01-22 10:58 ` [RFC PATCH v2 4/4] configure: Reword --enable-tcg-interpreter as --disable-native-tcg Philippe Mathieu-Daudé
2021-01-22 11:33   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc2847c8-d897-aad1-0b00-1f6b3b1211a2@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).