From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: vsementsov@virtuozzo.com, qemu-devel@nongnu.org,
stefanha@redhat.com, mreitz@redhat.com
Subject: Re: [PATCH 6/6] iotests: Test committing to short backing file
Date: Wed, 20 Nov 2019 08:52:27 -0600 [thread overview]
Message-ID: <fc338397-feba-5a1e-5ef1-9a68af788793@redhat.com> (raw)
In-Reply-To: <20191120140319.1505-7-kwolf@redhat.com>
On 11/20/19 8:03 AM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/274 | 131 +++++++++++++++++++++++++++++
> tests/qemu-iotests/274.out | 150 ++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> tests/qemu-iotests/iotests.py | 2 +-
> 4 files changed, 283 insertions(+), 1 deletion(-)
> create mode 100755 tests/qemu-iotests/274
> create mode 100644 tests/qemu-iotests/274.out
>
> +def create_chain():
> + iotests.qemu_img_log('create', '-f', iotests.imgfmt, base,
> + str(size_long))
> + iotests.qemu_img_log('create', '-f', iotests.imgfmt, '-b', base, mid,
> + str(size_short))
> + iotests.qemu_img_log('create', '-f', iotests.imgfmt, '-b', mid, top,
> + str(size_long))
> +
> + iotests.qemu_io_log('-c', 'write -P 1 0 %d' % size_long, base)
Matches the setup in the cover letter, and definitely exposes the issues
at hand.
Reviewed-by: Eric Blake <eblake@redhat.com>
As leaving this bug open represents a data leak/corruption to guests, I
think this series counts as worthy of -rc3.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-11-20 14:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 14:03 [PATCH for-4.2? 0/6] block: Fix resize (extending) of short overlays Kevin Wolf
2019-11-20 14:03 ` [PATCH 1/6] block: bdrv_co_do_pwrite_zeroes: 64 bit 'bytes' parameter Kevin Wolf
2019-11-20 14:14 ` Eric Blake
2019-11-20 14:27 ` Vladimir Sementsov-Ogievskiy
2019-11-20 16:18 ` Alberto Garcia
2019-11-20 14:03 ` [PATCH 2/6] block: truncate: Don't make backing file data visible Kevin Wolf
2019-11-20 14:20 ` Eric Blake
2019-11-20 14:47 ` Vladimir Sementsov-Ogievskiy
2019-11-20 15:12 ` Kevin Wolf
2019-11-20 18:01 ` Vladimir Sementsov-Ogievskiy
2019-11-25 11:06 ` Kevin Wolf
2019-11-20 14:03 ` [PATCH 3/6] iotests: Add qemu_io_log() Kevin Wolf
2019-11-20 14:26 ` Eric Blake
2019-11-20 14:49 ` Vladimir Sementsov-Ogievskiy
2019-11-20 14:03 ` [PATCH 4/6] iotests: Fix timeout in run_job() Kevin Wolf
2019-11-20 14:29 ` Eric Blake
2019-11-20 14:51 ` Vladimir Sementsov-Ogievskiy
2019-11-20 14:03 ` [PATCH 5/6] iotests: Support job-complete " Kevin Wolf
2019-11-20 14:46 ` Eric Blake
2019-11-20 14:56 ` Vladimir Sementsov-Ogievskiy
2019-11-20 14:03 ` [PATCH 6/6] iotests: Test committing to short backing file Kevin Wolf
2019-11-20 14:52 ` Eric Blake [this message]
2019-11-20 15:41 ` Vladimir Sementsov-Ogievskiy
2019-11-20 16:11 ` Kevin Wolf
2019-11-20 16:29 ` Vladimir Sementsov-Ogievskiy
2019-11-20 16:10 ` Vladimir Sementsov-Ogievskiy
2019-11-20 15:49 ` [PATCH for-4.2? 0/6] block: Fix resize (extending) of short overlays Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc338397-feba-5a1e-5ef1-9a68af788793@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).