From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Aishwarya Kadlag <aishwaryakadlag@gmail.com>,
qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V1]sm501: dead code removal
Date: Mon, 12 Mar 2018 10:17:15 +0100 [thread overview]
Message-ID: <fc423157-37c7-1085-aca6-439b497a2ab8@redhat.com> (raw)
In-Reply-To: <6666720e-6f5c-0e8c-6c5a-ac36d708e314@redhat.com>
On 12/03/2018 06:58, Thomas Huth wrote:
> I don't know the hw/display code very well, but I think it's not that
> easy... Putting Gerd on CC:, maybe he can describe the details of that
> BiteSizeTask a little bit better.
>
> (When sending patches, please also always use the get_maintainers.pl
> script to get a set of people who should be put on CC: or the patch
> might get lost in the high traffic of the qemu-devel mailing list).
It's _almost_ that easy.
First, get_depth_index must be adjusted to reflect that you have removed
the first three elements from the array. It doesn't hurt to add an
assert(surface_bits_per_pixel(surface) == 32)
in the function, too.
Second, the PIXEL_TYPE macro in sm501_template.h now is always uint32_t
and it can be replaced everywhere. Likewise for BPP, which is always 4,
and DEPTH, which is always 32.
Thanks!
Paolo
prev parent reply other threads:[~2018-03-12 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 16:40 [Qemu-devel] [PATCH V1]sm501: dead code removal Aishwarya Kadlag
2018-03-12 5:58 ` Thomas Huth
2018-03-12 7:05 ` Gerd Hoffmann
2018-03-12 7:35 ` Thomas Huth
2018-03-12 13:03 ` Peter Maydell
2018-03-12 17:58 ` Aishwarya Kadlag
2018-03-12 9:17 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc423157-37c7-1085-aca6-439b497a2ab8@redhat.com \
--to=pbonzini@redhat.com \
--cc=aishwaryakadlag@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).