From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3lkI-0001qJ-Sr for qemu-devel@nongnu.org; Fri, 20 May 2016 10:49:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3lkE-00065v-Os for qemu-devel@nongnu.org; Fri, 20 May 2016 10:49:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3lkE-00065r-It for qemu-devel@nongnu.org; Fri, 20 May 2016 10:49:42 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7DA4115568 for ; Fri, 20 May 2016 14:49:41 +0000 (UTC) References: <543c98f507a30a92c42f1d240b47ad90f0efdad3.1463588606.git.crobinso@redhat.com> <1463723606.3526.7.camel@redhat.com> From: Cole Robinson Message-ID: Date: Fri, 20 May 2016 10:49:40 -0400 MIME-Version: 1.0 In-Reply-To: <1463723606.3526.7.camel@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable virgl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org On 05/20/2016 01:53 AM, Gerd Hoffmann wrote: > On Mi, 2016-05-18 at 12:40 -0400, Cole Robinson wrote: >> Give users a hint if their config is wrong. >> >> Signed-off-by: Cole Robinson >> --- >> If virgl support is built into qemu, virgl=on is the default, so this >> could be noisy in cases where people don't even care about virgl. So >> I won't object if this is dropped. > > Yes, it's enabled by default, so users have to flip one switch only > (-spice gl=on) to enable 3d, not two. So warning here is a bad thing > IMO. > > We could turn the virgl switch into tristate (OnOffAuto), have it > default to Auto, then fail (not warn) in case it is set to On without 3d > support being available. > Property settings are part of the migration format, right? Is there an easy way to change the 'virgl' property like that in a backwards compatible way? Or decouple the command line handling from the Property value? Thanks, Cole