From: "Cédric Le Goater" <clg@kaod.org>
To: Jamin Lin <jamin_lin@aspeedtech.com>,
Peter Maydell <peter.maydell@linaro.org>,
Steven Lee <steven_lee@aspeedtech.com>,
Troy Lee <leetroy@gmail.com>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>, Fabiano Rosas <farosas@suse.de>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: troy_lee@aspeedtech.com, yunlin.tang@aspeedtech.com
Subject: Re: [PATCH v3 09/10] test/qtest: Introduce a new aspeed-smc-utils.c to place common testcases
Date: Mon, 9 Dec 2024 14:09:14 +0100 [thread overview]
Message-ID: <fc4983c3-56a8-4ee4-83d7-f14435805763@kaod.org> (raw)
In-Reply-To: <20241127091543.1243114-10-jamin_lin@aspeedtech.com>
On 11/27/24 10:15, Jamin Lin wrote:
> The testcases for ASPEED SMC model were placed in aspeed_smc-test.c.
> However, this test file only supports for ARM32. To support all ASPEED SOCs
> such as AST2700 whose CPU architecture is aarch64, introduces a new
> aspeed-smc-utils source file and move all common APIs and testcases
> from aspeed_smc-test.c to aspeed-smc-utils.c.
>
> Finally, users are able to re-used these testcase for AST2700 and future
> ASPEED SOCs testing.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
> tests/qtest/aspeed-smc-utils.c | 686 ++++++++++++++++++++++++++++
> tests/qtest/aspeed-smc-utils.h | 95 ++++
> tests/qtest/aspeed_smc-test.c | 800 +++------------------------------
> tests/qtest/meson.build | 1 +
> 4 files changed, 841 insertions(+), 741 deletions(-)
> create mode 100644 tests/qtest/aspeed-smc-utils.c
> create mode 100644 tests/qtest/aspeed-smc-utils.h
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Thanks,
C.
next prev parent reply other threads:[~2024-12-09 13:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 9:15 [PATCH v3 00/10] Add smc qtest testcase to support AST2700 Jamin Lin via
2024-11-27 9:15 ` [PATCH v3 01/10] test/qtest/aspeed_smc-test: Move testcases to test_palmetto_bmc function Jamin Lin via
2024-11-27 9:15 ` [PATCH v3 02/10] test/qtest/aspeed_smc-test: Introduce a new TestData to test different BMC SOCs Jamin Lin via
2024-11-27 9:15 ` [PATCH v3 03/10] test/qtest/aspeed_smc-test: Support to test all CE pins Jamin Lin via
2024-11-27 9:15 ` [PATCH v3 04/10] test/qtest/aspeed_smc-test: Introducing a "page_addr" data field Jamin Lin via
2024-11-27 9:15 ` [PATCH v3 05/10] test/qtest/aspeed_smc-test: Support to test AST2500 Jamin Lin via
2024-11-27 9:15 ` [PATCH v3 06/10] test/qtest/aspeed_smc-test: Support to test AST2600 Jamin Lin via
2024-11-27 9:15 ` [PATCH v3 07/10] test/qtest/aspeed_smc-test: Support to test AST1030 Jamin Lin via
2024-11-27 9:15 ` [PATCH v3 08/10] test/qtest/aspeed_smc-test: Support write page command with QPI mode Jamin Lin via
2024-11-27 9:15 ` [PATCH v3 09/10] test/qtest: Introduce a new aspeed-smc-utils.c to place common testcases Jamin Lin via
2024-12-09 13:09 ` Cédric Le Goater [this message]
2024-11-27 9:15 ` [PATCH v3 10/10] test/qtest/ast2700-smc-test: Support to test AST2700 Jamin Lin via
2024-12-09 13:09 ` Cédric Le Goater
2024-12-09 13:36 ` [PATCH v3 00/10] Add smc qtest testcase to support AST2700 Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc4983c3-56a8-4ee4-83d7-f14435805763@kaod.org \
--to=clg@kaod.org \
--cc=andrew@codeconstruct.com.au \
--cc=farosas@suse.de \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
--cc=yunlin.tang@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).