From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D485C54E58 for ; Mon, 11 Mar 2024 16:00:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rji4C-0005nx-7x; Mon, 11 Mar 2024 11:59:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rji42-0005nE-4c; Mon, 11 Mar 2024 11:59:46 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rji3y-0002iv-AS; Mon, 11 Mar 2024 11:59:44 -0400 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42BFv1Ov023454; Mon, 11 Mar 2024 15:59:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=I4/87NwvqqpaViSus1M0u8GL8324PD7DEG4oFOBPYao=; b=avrI2ImdACmxu0euDm6GzcKwsER9RxVZ0KKTLwYDkhKVwOb4FnPTiSGaGw4fKgW3t+z3 FhW96nBQk1yX6srpwdYh5A88f+1c501fYPMSSRZom8sr9sxVbFnhNK7zF7AqxYMa4wsO hJ7CUA//OU0yQ7t8CfvTaQunpTb+n994o2zeCy1Qrw77Y5Fnkngj5/NWhqBpund1cqeE cV+tBM63q+aOu1R/XC4O1WsolRuCiusYgsamAla/LPHcub3Xfrq1lMBq6ZvR0/cgwmRE 1bOvltMuFhTCWW7Nd56Fe2jVpnYkCt8qYtnK9fKvTx3yWVhz+isjU1i0aJJrxL41dy2E ow== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wt51xr22t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Mar 2024 15:59:24 +0000 Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 42BFv1rB023458; Mon, 11 Mar 2024 15:59:23 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wt51xr213-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Mar 2024 15:59:23 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 42BCxjef015501; Mon, 11 Mar 2024 15:55:09 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ws2fyhkkn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Mar 2024 15:55:09 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 42BFt6Qg49152378 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Mar 2024 15:55:08 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B55D55805F; Mon, 11 Mar 2024 15:55:04 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3578958063; Mon, 11 Mar 2024 15:55:03 +0000 (GMT) Received: from li-479af74c-31f9-11b2-a85c-e4ddee11713b.ibm.com (unknown [9.61.78.110]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 11 Mar 2024 15:55:03 +0000 (GMT) Message-ID: Subject: Re: [PATCH v1 5/8] virtio-ccw: Handle extra notification data From: Eric Farman To: Jonah Palmer , qemu-devel@nongnu.org Cc: mst@redhat.com, jasowang@redhat.com, eperezma@redhat.com, si-wei.liu@oracle.com, boris.ostrovsky@oracle.com, raphael@enfabrica.net, kwolf@redhat.com, hreitz@redhat.com, pasic@linux.ibm.com, borntraeger@linux.ibm.com, thuth@redhat.com, richard.henderson@linaro.org, david@redhat.com, iii@linux.ibm.com, cohuck@redhat.com, pbonzini@redhat.com, fam@euphon.net, stefanha@redhat.com, qemu-block@nongnu.org, qemu-s390x@nongnu.org, virtio-fs@lists.linux.dev Date: Mon, 11 Mar 2024 11:55:02 -0400 In-Reply-To: <20240304194612.611660-6-jonah.palmer@oracle.com> References: <20240304194612.611660-1-jonah.palmer@oracle.com> <20240304194612.611660-6-jonah.palmer@oracle.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: LUccPnyA8u9cmmjVLmBtSnDRsv9dmHzP X-Proofpoint-ORIG-GUID: JFrUGpsd7t7ObrPTsvUw5GvQ_IrfaY_I X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-11_10,2024-03-11_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 spamscore=0 clxscore=1011 mlxlogscore=999 impostorscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403110121 Received-SPF: pass client-ip=148.163.156.1; envelope-from=farman@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, 2024-03-04 at 14:46 -0500, Jonah Palmer wrote: > > Add support to virtio-ccw devices for handling the extra data sent > > from > > the driver to the device when the VIRTIO_F_NOTIFICATION_DATA > > transport > > feature has been negotiated. > >=20 > > The extra data that's passed to the virtio-ccw device when this > > feature > > is enabled varies depending on the device's virtqueue layout. > >=20 > > That data passed to the virtio-ccw device is in the same format as > > the > > data passed to virtio-pci devices. > >=20 > > Acked-by: Thomas Huth > > Signed-off-by: Jonah Palmer > > --- > > =C2=A0hw/s390x/s390-virtio-ccw.c | 16 ++++++++++++---- > > =C2=A01 file changed, 12 insertions(+), 4 deletions(-) Acked-by: Eric Farman (I see a v2 is coming for the ioeventfd side, but I was going through this series today and thought that would affect the next patch rather than this one.)