* [Qemu-devel] [PATCH] hw/arm/virt: Add support for Cortex-A7
@ 2019-06-30 15:13 Jan Kiszka
2019-07-01 9:36 ` Philippe Mathieu-Daudé
2019-07-01 11:16 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Jan Kiszka @ 2019-06-30 15:13 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-arm
From: Jan Kiszka <jan.kiszka@siemens.com>
No reason to deny this type.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/arm/virt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 431e2900fd..ed009fa447 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -176,6 +176,7 @@ static const int a15irqmap[] = {
};
static const char *valid_cpus[] = {
+ ARM_CPU_TYPE_NAME("cortex-a7"),
ARM_CPU_TYPE_NAME("cortex-a15"),
ARM_CPU_TYPE_NAME("cortex-a53"),
ARM_CPU_TYPE_NAME("cortex-a57"),
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/arm/virt: Add support for Cortex-A7
2019-06-30 15:13 [Qemu-devel] [PATCH] hw/arm/virt: Add support for Cortex-A7 Jan Kiszka
@ 2019-07-01 9:36 ` Philippe Mathieu-Daudé
2019-07-01 11:16 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-07-01 9:36 UTC (permalink / raw)
To: Jan Kiszka, Peter Maydell, qemu-devel, qemu-arm
On 6/30/19 5:13 PM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> No reason to deny this type.
Maybe add "As the A15, it supports the EL2/V7VE features."?
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/arm/virt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 431e2900fd..ed009fa447 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -176,6 +176,7 @@ static const int a15irqmap[] = {
> };
>
> static const char *valid_cpus[] = {
> + ARM_CPU_TYPE_NAME("cortex-a7"),
> ARM_CPU_TYPE_NAME("cortex-a15"),
> ARM_CPU_TYPE_NAME("cortex-a53"),
> ARM_CPU_TYPE_NAME("cortex-a57"),
Should we list here all cpu with arm_feature(ARM_FEATURE_V7VE | V8)? or EL2?
> --
> 2.16.4
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/arm/virt: Add support for Cortex-A7
2019-06-30 15:13 [Qemu-devel] [PATCH] hw/arm/virt: Add support for Cortex-A7 Jan Kiszka
2019-07-01 9:36 ` Philippe Mathieu-Daudé
@ 2019-07-01 11:16 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2019-07-01 11:16 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-arm, qemu-devel
On Sun, 30 Jun 2019 at 16:13, Jan Kiszka <jan.kiszka@web.de> wrote:
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> No reason to deny this type.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/arm/virt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 431e2900fd..ed009fa447 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -176,6 +176,7 @@ static const int a15irqmap[] = {
> };
>
> static const char *valid_cpus[] = {
> + ARM_CPU_TYPE_NAME("cortex-a7"),
> ARM_CPU_TYPE_NAME("cortex-a15"),
> ARM_CPU_TYPE_NAME("cortex-a53"),
> ARM_CPU_TYPE_NAME("cortex-a57"),
> --
Applied to target-arm.next (with a commit message tweak
along the lines suggested by Philippe), thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-01 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-30 15:13 [Qemu-devel] [PATCH] hw/arm/virt: Add support for Cortex-A7 Jan Kiszka
2019-07-01 9:36 ` Philippe Mathieu-Daudé
2019-07-01 11:16 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).