From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8ThU-0003Ar-K7 for qemu-devel@nongnu.org; Wed, 10 May 2017 11:38:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8ThS-0005uz-23 for qemu-devel@nongnu.org; Wed, 10 May 2017 11:38:52 -0400 References: <20170510092903.23649-1-marcel@redhat.com> From: Paolo Bonzini Message-ID: Date: Wed, 10 May 2017 17:38:45 +0200 MIME-Version: 1.0 In-Reply-To: <20170510092903.23649-1-marcel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Revert "hw/pci: disable pci-bridge's shpc by default" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, mst@redhat.com On 10/05/2017 11:29, Marcel Apfelbaum wrote: > +++ b/hw/pci-bridge/pci_bridge_dev.c > @@ -163,7 +163,7 @@ static Property pci_bridge_dev_properties[] = { > DEFINE_PROP_ON_OFF_AUTO(PCI_BRIDGE_DEV_PROP_MSI, PCIBridgeDev, msi, > ON_OFF_AUTO_AUTO), > DEFINE_PROP_BIT(PCI_BRIDGE_DEV_PROP_SHPC, PCIBridgeDev, flags, > - PCI_BRIDGE_DEV_F_SHPC_REQ, false), > + PCI_BRIDGE_DEV_F_SHPC_REQ, true), > DEFINE_PROP_END_OF_LIST(), > }; > > diff --git a/include/hw/compat.h b/include/hw/compat.h > index 846b90e..eff021f 100644 > --- a/include/hw/compat.h > +++ b/include/hw/compat.h > @@ -18,10 +18,6 @@ > .property = "old-multiple-chip-handling",\ > .value = "on",\ > },{\ > - .driver = "pci-bridge",\ > - .property = "shpc",\ > - .value = "on",\ > - },{\ Unless we make a conscious decision to break PCI bridge backwards compatibility, you now have to disable it for 2.9 and leave this HW_COMPAT_2_8 hunk intact. Peter Xu has a patch to add the 2.10 machine types. Paolo > .driver = TYPE_PCI_DEVICE,\ > .property = "x-pcie-extcap-init",\ > .value = "off",\ > -- 2.9.3