qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Mathis Marion <Mathis.Marion@silabs.com>,
	Laurent Vivier <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org, "Jérôme Pouiller" <jerome.pouiller@silabs.com>
Subject: Re: [PATCH v2 2/4] linux-user: fix sockaddr_in6 endianness
Date: Mon, 20 Feb 2023 10:06:41 +0100	[thread overview]
Message-ID: <fc6b4e3f-378f-f415-79b9-79afbaef93ba@linaro.org> (raw)
In-Reply-To: <20230220085822.626798-3-Mathis.Marion@silabs.com>

On 20/2/23 09:58, Mathis Marion wrote:
> From: Mathis Marion <mathis.marion@silabs.com>
> 
> Fields sin6_flowinfo and sin6_scope_id use the host byte order, so there
> is a conversion to be made when host and target endianness differ.
> 
> Signed-off-by: Mathis Marion <mathis.marion@silabs.com>
> ---
>   linux-user/syscall.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 58549de125..1a6856abec 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -1713,6 +1713,12 @@ static inline abi_long target_to_host_sockaddr(int fd, struct sockaddr *addr,
>   	lladdr = (struct target_sockaddr_ll *)addr;
>   	lladdr->sll_ifindex = tswap32(lladdr->sll_ifindex);
>   	lladdr->sll_hatype = tswap16(lladdr->sll_hatype);
> +    } else if (sa_family == AF_INET6) {
> +        struct sockaddr_in6 *in6addr;
> +
> +        in6addr = (struct sockaddr_in6 *)addr;
> +        in6addr->sin6_flowinfo = tswap32(in6addr->sin6_flowinfo);
> +        in6addr->sin6_scope_id = tswap32(in6addr->sin6_scope_id);
>       }
>       unlock_user(target_saddr, target_addr, 0);
>   

Same content as v1, right?

If you don't change patch content, please include the reviewer tags
so we don't have to review your patches again.

So similarly to
https://lore.kernel.org/qemu-devel/6be6bf58-cf92-7068-008e-83f5543a1f01@linaro.org/
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2023-02-20  9:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20  8:58 [PATCH v2 0/4] Missing endianness conversions in user mode Mathis Marion
2023-02-20  8:58 ` [PATCH v2 1/4] linux-user: fix timerfd read endianness conversion Mathis Marion
2023-03-06 21:42   ` Laurent Vivier
2023-03-07  9:33   ` Laurent Vivier
2023-02-20  8:58 ` [PATCH v2 2/4] linux-user: fix sockaddr_in6 endianness Mathis Marion
2023-02-20  9:06   ` Philippe Mathieu-Daudé [this message]
2023-02-20  9:09     ` Mathis MARION
2023-02-20  9:32       ` Philippe Mathieu-Daudé
2023-03-06 21:52   ` Laurent Vivier
2023-03-07 11:27     ` Mathis MARION
2023-03-07 13:37       ` Laurent Vivier
2023-02-20  8:58 ` [PATCH v2 3/4] linux-user: add target to host netlink conversions Mathis Marion
2023-02-20  9:04   ` Philippe Mathieu-Daudé
2023-03-06 22:02   ` Laurent Vivier
2023-03-07  9:32   ` Laurent Vivier
2023-02-20  8:58 ` [PATCH v2 4/4] linux-user: handle netlink flag NLA_F_NESTED Mathis Marion
2023-02-20  9:15   ` Mathis MARION
2023-04-01  9:19 ` [PATCH v2 0/4] Missing endianness conversions in user mode Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc6b4e3f-378f-f415-79b9-79afbaef93ba@linaro.org \
    --to=philmd@linaro.org \
    --cc=Mathis.Marion@silabs.com \
    --cc=jerome.pouiller@silabs.com \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).