* [PATCH] trivial: Remove extra character in configure help
@ 2020-06-24 8:33 Christophe de Dinechin
2020-06-24 8:38 ` Christophe de Dinechin
2020-06-24 8:59 ` Daniel P. Berrangé
0 siblings, 2 replies; 4+ messages in thread
From: Christophe de Dinechin @ 2020-06-24 8:33 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Michael Tokarev, Laurent Vivier
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index ba88fd1824..c7a6a5adfe 100755
--- a/configure
+++ b/configure
@@ -1787,7 +1787,7 @@ Advanced options (experts only):
--block-drv-ro-whitelist=L
set block driver read-only whitelist
(affects only QEMU, not qemu-img)
- --enable-trace-backends=B Set trace backend
+ --enable-trace-backends= Set trace backend
Available backends: $trace_backend_list
--with-trace-file=NAME Full PATH,NAME of file to store traces
Default:trace-<pid>
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] trivial: Remove extra character in configure help
2020-06-24 8:33 [PATCH] trivial: Remove extra character in configure help Christophe de Dinechin
@ 2020-06-24 8:38 ` Christophe de Dinechin
2020-06-24 8:59 ` Daniel P. Berrangé
1 sibling, 0 replies; 4+ messages in thread
From: Christophe de Dinechin @ 2020-06-24 8:38 UTC (permalink / raw)
To: Michael Tokarev, Laurent Vivier; +Cc: qemu-trivial, GitLab via
Please ignore. The =B appears intentional, even if it offsets the whole help text.
Maybe replace with =L to indicate a list is expected?
> On 24 Jun 2020, at 10:33, Christophe de Dinechin <dinechin@redhat.com> wrote:
>
> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index ba88fd1824..c7a6a5adfe 100755
> --- a/configure
> +++ b/configure
> @@ -1787,7 +1787,7 @@ Advanced options (experts only):
> --block-drv-ro-whitelist=L
> set block driver read-only whitelist
> (affects only QEMU, not qemu-img)
> - --enable-trace-backends=B Set trace backend
> + --enable-trace-backends= Set trace backend
> Available backends: $trace_backend_list
> --with-trace-file=NAME Full PATH,NAME of file to store traces
> Default:trace-<pid>
> --
> 2.26.2
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] trivial: Remove extra character in configure help
2020-06-24 8:33 [PATCH] trivial: Remove extra character in configure help Christophe de Dinechin
2020-06-24 8:38 ` Christophe de Dinechin
@ 2020-06-24 8:59 ` Daniel P. Berrangé
2020-06-24 9:09 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Daniel P. Berrangé @ 2020-06-24 8:59 UTC (permalink / raw)
To: Christophe de Dinechin
Cc: qemu-trivial, Michael Tokarev, qemu-devel, Laurent Vivier
On Wed, Jun 24, 2020 at 10:33:37AM +0200, Christophe de Dinechin wrote:
> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index ba88fd1824..c7a6a5adfe 100755
> --- a/configure
> +++ b/configure
> @@ -1787,7 +1787,7 @@ Advanced options (experts only):
> --block-drv-ro-whitelist=L
> set block driver read-only whitelist
> (affects only QEMU, not qemu-img)
> - --enable-trace-backends=B Set trace backend
> + --enable-trace-backends= Set trace backend
This is just following the style of the option above. "B" is a
placeholder for the desired backend(s).
> Available backends: $trace_backend_list
> --with-trace-file=NAME Full PATH,NAME of file to store traces
> Default:trace-<pid>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] trivial: Remove extra character in configure help
2020-06-24 8:59 ` Daniel P. Berrangé
@ 2020-06-24 9:09 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-24 9:09 UTC (permalink / raw)
To: Daniel P. Berrangé, Christophe de Dinechin
Cc: qemu-trivial, Michael Tokarev, qemu-devel, Laurent Vivier
On 6/24/20 10:59 AM, Daniel P. Berrangé wrote:
> On Wed, Jun 24, 2020 at 10:33:37AM +0200, Christophe de Dinechin wrote:
>> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index ba88fd1824..c7a6a5adfe 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1787,7 +1787,7 @@ Advanced options (experts only):
>> --block-drv-ro-whitelist=L
>> set block driver read-only whitelist
>> (affects only QEMU, not qemu-img)
>> - --enable-trace-backends=B Set trace backend
>> + --enable-trace-backends= Set trace backend
>
> This is just following the style of the option above. "B" is a
> placeholder for the desired backend(s).
I agree this is confusing, since then the filename is NAME, not N.
Maybe clearer to replace B -> BACKEND, L -> LIST, ...?
>
>> Available backends: $trace_backend_list
>> --with-trace-file=NAME Full PATH,NAME of file to store traces
>> Default:trace-<pid>
>
>
> Regards,
> Daniel
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-24 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-24 8:33 [PATCH] trivial: Remove extra character in configure help Christophe de Dinechin
2020-06-24 8:38 ` Christophe de Dinechin
2020-06-24 8:59 ` Daniel P. Berrangé
2020-06-24 9:09 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).